third_party/WebKit/Source/modules/background_sync/SyncCallbacks.h - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/background_sync/SyncCallbacks.h

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h ('k') | third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp » ('j') | third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/background_sync/SyncCallbacks.h

diff --git a/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.h b/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.h

index d4ad48722480f8b2e05d0647b4c8678431c1bc53..a5dc89abe35db229baa92ab519c8246eeb4e4a23 100644

--- a/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.h

+++ b/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.h

@@ -34,7 +34,7 @@ public:

SyncRegistrationCallbacks(ScriptPromiseResolver*, ServiceWorkerRegistration*);

~SyncRegistrationCallbacks() override;

- void onSuccess(WebPassOwnPtr<WebSyncRegistration>) override;

+ void onSuccess(std::unique_ptr<WebSyncRegistration>) override;

void onError(const WebSyncError&) override;

private: