Roll WebGL 863cabb..8b636f3

Roll WebGL 863cabb..8b636f3

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/863cabb..8b636f3

BUG=599333
TEST=bots
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
TBR=zmo@chromium.org

Committed: https://crrev.com/b29213143d5a6da0732ae661fc1dc0cacf13b84c
Cr-Commit-Position: refs/heads/master@{#385552}

[Ken Russell (switch to Gerrit), 2016-04-06 19:17:44]

Description was changed from

==========
Roll WebGL 863cabb..8b636f3

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/863cab...

BUG=

TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Roll WebGL 863cabb..8b636f3

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/863cab...

BUG=599333

TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-04-06 19:17:44]

kbr@chromium.org changed reviewers:
+ zmo@chromium.org

[Ken Russell (switch to Gerrit), 2016-04-06 19:17:55]

Description was changed from

==========
Roll WebGL 863cabb..8b636f3

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/863cab...

BUG=599333

TEST=bots

CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Roll WebGL 863cabb..8b636f3

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/863cab...

BUG=599333
TEST=bots
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
TBR=zmo@chromium.org
==========

[Ken Russell (switch to Gerrit), 2016-04-06 19:18:46]

FYI. CQ'ing TBR'd.

If this CL causes test breakage only on the FYI waterfall that isn't caught by
the CQ, please don't revert it, but either add more suppressions or existing
ones. Thanks.

[Ken Russell (switch to Gerrit), 2016-04-06 19:19:01]

On 2016/04/06 19:18:46, Ken Russell wrote:
> FYI. CQ'ing TBR'd.
> 
> If this CL causes test breakage only on the FYI waterfall that isn't caught by
> the CQ, please don't revert it, but either add more suppressions or existing
> ones. Thanks.

..."or fix existing ones".

[Ken Russell (switch to Gerrit), 2016-04-06 19:19:05]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-04-06 19:19:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1865913003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1865913003/20001

[Jamie Madill, 2016-04-06 19:28:37]

jmadill@chromium.org changed reviewers:
+ jmadill@chromium.org

[Jamie Madill, 2016-04-06 19:28:38]

Why doesn't this have the linux bots in the try list? It's almost guaranteed to
break the ANGLE CQ.

[commit-bot: I haz the power, 2016-04-06 20:52:22]

Description was changed from

==========
Roll WebGL 863cabb..8b636f3

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/863cab...

BUG=599333
TEST=bots
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
TBR=zmo@chromium.org
==========

to

==========
Roll WebGL 863cabb..8b636f3

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/863cab...

BUG=599333
TEST=bots
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
TBR=zmo@chromium.org
==========

[commit-bot: I haz the power, 2016-04-06 20:52:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-06 20:53:34]

Description was changed from

==========
Roll WebGL 863cabb..8b636f3

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/863cab...

BUG=599333
TEST=bots
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
TBR=zmo@chromium.org
==========

to

==========
Roll WebGL 863cabb..8b636f3

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/863cab...

BUG=599333
TEST=bots
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
TBR=zmo@chromium.org

Committed: https://crrev.com/b29213143d5a6da0732ae661fc1dc0cacf13b84c
Cr-Commit-Position: refs/heads/master@{#385552}
==========

[commit-bot: I haz the power, 2016-04-06 20:53:35]

Patchset 2 (id:??) landed as
https://crrev.com/b29213143d5a6da0732ae661fc1dc0cacf13b84c
Cr-Commit-Position: refs/heads/master@{#385552}

[Zhenyao Mo, 2016-04-06 21:01:05]

On 2016/04/06 20:53:35, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/b29213143d5a6da0732ae661fc1dc0cacf13b84c
> Cr-Commit-Position: refs/heads/master@{#385552}

Jamie, why do you think it will fail the linux bots?  Assuming you mean
linux_optional_gpu_tests_rel.

This try bot wasn't in good enough shape to be added last time I added the mac
optional one.  If it's stable now, we should add it.

[Jamie Madill, 2016-04-06 21:07:45]

On 2016/04/06 21:01:05, Zhenyao Mo wrote:
> On 2016/04/06 20:53:35, commit-bot: I haz the power wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/b29213143d5a6da0732ae661fc1dc0cacf13b84c
> > Cr-Commit-Position: refs/heads/master@{#385552}
> 
> Jamie, why do you think it will fail the linux bots?  Assuming you mean
> linux_optional_gpu_tests_rel.
>
> This try bot wasn't in good enough shape to be added last time I added the mac
> optional one.  If it's stable now, we should add it.

Well, I added it in https://codereview.chromium.org/1807483002/. Don't know why
it isn't firing.. unless it's been reverted?

[Ken Russell (switch to Gerrit), 2016-04-06 21:37:01]

On 2016/04/06 21:07:45, Jamie Madill wrote:
> On 2016/04/06 21:01:05, Zhenyao Mo wrote:
> > On 2016/04/06 20:53:35, commit-bot: I haz the power wrote:
> > > Patchset 2 (id:??) landed as
> > > https://crrev.com/b29213143d5a6da0732ae661fc1dc0cacf13b84c
> > > Cr-Commit-Position: refs/heads/master@{#385552}
> > 
> > Jamie, why do you think it will fail the linux bots?  Assuming you mean
> > linux_optional_gpu_tests_rel.
> >
> > This try bot wasn't in good enough shape to be added last time I added the
mac
> > optional one.  If it's stable now, we should add it.
> 
> Well, I added it in https://codereview.chromium.org/1807483002/. Don't know
why
> it isn't firing.. unless it's been reverted?

That modification adds linux_optional_gpu_tests_rel to any change under src/gpu/
. It's necessary to add it to the roll_webgl_conformance.py script, roll_angle
and other PRESUBMIT.py scripts. See https://codereview.chromium.org/1682593002
for a CL which touched all of these files.

[Jamie Madill, 2016-04-06 21:38:32]

On 2016/04/06 21:37:01, Ken Russell wrote:
> On 2016/04/06 21:07:45, Jamie Madill wrote:
> > On 2016/04/06 21:01:05, Zhenyao Mo wrote:
> > > On 2016/04/06 20:53:35, commit-bot: I haz the power wrote:
> > > > Patchset 2 (id:??) landed as
> > > > https://crrev.com/b29213143d5a6da0732ae661fc1dc0cacf13b84c
> > > > Cr-Commit-Position: refs/heads/master@{#385552}
> > > 
> > > Jamie, why do you think it will fail the linux bots?  Assuming you mean
> > > linux_optional_gpu_tests_rel.
> > >
> > > This try bot wasn't in good enough shape to be added last time I added the
> mac
> > > optional one.  If it's stable now, we should add it.
> > 
> > Well, I added it in https://codereview.chromium.org/1807483002/. Don't know
> why
> > it isn't firing.. unless it's been reverted?
> 
> That modification adds linux_optional_gpu_tests_rel to any change under
src/gpu/
> . It's necessary to add it to the roll_webgl_conformance.py script, roll_angle
> and other PRESUBMIT.py scripts. See https://codereview.chromium.org/1682593002
> for a CL which touched all of these files.

Gotcha, thanks, zmo also clarified this. I'll look at adding that.