Run WebGL 2.0 conformance tests in more cases.

Run WebGL 2.0 conformance tests in more cases.

Use CQ_INCLUDE_TRYBOTS directive to run optional GPU tests, which
include the WebGL 2.0 conformance tests, on the commit queue during
ANGLE rolls. Add a script for rolling the WebGL conformance suite and do
the same then.

Add presubmit checks for the gpu/ directory and the Blink WebGL sources
which run the WebGL 2.0 conformance suite, since these are the places
most likely to break these tests.

(These tests will be run by default on the commit queue as soon as there
is machine capacity to do so.)

BUG=295792
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=thakis@chromium.org

Committed: https://crrev.com/e85ee566e1458ec56cb0fd6ca0c5c081c6d6d485
Cr-Commit-Position: refs/heads/master@{#374307}

[Ken Russell (switch to Gerrit), 2016-02-08 23:01:27]

Description was changed from

==========
Run WebGL 2.0 conformance tests in more cases.

Use CQ_INCLUDE_TRYBOTS directive to run optional GPU tests, which
include the WebGL 2.0 conformance tests, on the commit queue during
ANGLE rolls. Add a script for rolling the WebGL conformance suite and do
the same then.

Add presubmit checks for the gpu/ directory and the Blink WebGL sources
which run the WebGL 2.0 conformance suite, since these are the places
most likely to break these tests.

(These tests will be run by default on the commit queue as soon as there
is machine capacity to do so.)

BUG=295792
==========

to

==========
Run WebGL 2.0 conformance tests in more cases.

Use CQ_INCLUDE_TRYBOTS directive to run optional GPU tests, which
include the WebGL 2.0 conformance tests, on the commit queue during
ANGLE rolls. Add a script for rolling the WebGL conformance suite and do
the same then.

Add presubmit checks for the gpu/ directory and the Blink WebGL sources
which run the WebGL 2.0 conformance suite, since these are the places
most likely to break these tests.

(These tests will be run by default on the commit queue as soon as there
is machine capacity to do so.)

BUG=295792
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-02-08 23:06:55]

kbr@chromium.org changed reviewers:
+ bajones@chromium.org, geofflang@chromium.org, piman@chromium.org,
sievers@chromium.org, zmo@chromium.org

[Ken Russell (switch to Gerrit), 2016-02-08 23:06:56]

piman/sievers: OWNERS review of gpu/ please

bajones/zmo/geofflang: please review other changes.

Others: FYI.

[piman, 2016-02-09 00:27:02]

lgtm

[Ken Russell (switch to Gerrit), 2016-02-09 00:29:57]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-02-09 00:34:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1682593002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1682593002/20001

[commit-bot: I haz the power, 2016-02-09 00:57:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 00:57:08]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ken Russell (switch to Gerrit), 2016-02-09 00:59:31]

Description was changed from

==========
Run WebGL 2.0 conformance tests in more cases.

Use CQ_INCLUDE_TRYBOTS directive to run optional GPU tests, which
include the WebGL 2.0 conformance tests, on the commit queue during
ANGLE rolls. Add a script for rolling the WebGL conformance suite and do
the same then.

Add presubmit checks for the gpu/ directory and the Blink WebGL sources
which run the WebGL 2.0 conformance suite, since these are the places
most likely to break these tests.

(These tests will be run by default on the commit queue as soon as there
is machine capacity to do so.)

BUG=295792
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Run WebGL 2.0 conformance tests in more cases.

Use CQ_INCLUDE_TRYBOTS directive to run optional GPU tests, which
include the WebGL 2.0 conformance tests, on the commit queue during
ANGLE rolls. Add a script for rolling the WebGL conformance suite and do
the same then.

Add presubmit checks for the gpu/ directory and the Blink WebGL sources
which run the WebGL 2.0 conformance suite, since these are the places
most likely to break these tests.

(These tests will be run by default on the commit queue as soon as there
is machine capacity to do so.)

BUG=295792
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=thakis@chromium.org
==========

[Ken Russell (switch to Gerrit), 2016-02-09 00:59:31]

kbr@chromium.org changed reviewers:
+ thakis@chromium.org

[Ken Russell (switch to Gerrit), 2016-02-09 00:59:40]

thakis: TBR'ing the OWNERS change to you.

[Ken Russell (switch to Gerrit), 2016-02-09 00:59:44]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-02-09 01:07:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1682593002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1682593002/20001

[Nico, 2016-02-09 01:23:14]

thakis@chromium.org changed reviewers:
+ agable@chromium.org, kjellander@chromium.org

[Nico, 2016-02-09 01:23:14]

Is it possible to make this less copy-pasta-y? When I wanted to land a similar
script for pdfium in https://codereview.chromium.org/1289873005/ , kjellander
and agable both told me not to do that (with the effect of me ferrying the
script around locally, which isn't the best outcome either :-P)

Anyhoo, owners lgtm

[Ken Russell (switch to Gerrit), 2016-02-09 01:28:40]

On 2016/02/09 01:23:14, Nico wrote:
> Is it possible to make this less copy-pasta-y? When I wanted to land a similar
> script for pdfium in https://codereview.chromium.org/1289873005/ , kjellander
> and agable both told me not to do that (with the effect of me ferrying the
> script around locally, which isn't the best outcome either :-P)

Yes, code could certainly be shared among these scripts. Each DEPS entry would
need its own extra trybots, commit message generation hooks, etc. I'm
disappointed that your other CL was rejected since it would have saved you work.
I'm going ahead with this patch since it is needed to save time and effort in
the long run. I would be happy to help if someone from the infra team wants to
generalize and/or get rid of these scripts.

[commit-bot: I haz the power, 2016-02-09 02:41:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 02:41:57]

Try jobs failed on following builders:
  win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)

[Ken Russell (switch to Gerrit), 2016-02-09 03:21:35]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-02-09 03:24:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1682593002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1682593002/20001

[commit-bot: I haz the power, 2016-02-09 04:37:41]

Description was changed from

==========
Run WebGL 2.0 conformance tests in more cases.

Use CQ_INCLUDE_TRYBOTS directive to run optional GPU tests, which
include the WebGL 2.0 conformance tests, on the commit queue during
ANGLE rolls. Add a script for rolling the WebGL conformance suite and do
the same then.

Add presubmit checks for the gpu/ directory and the Blink WebGL sources
which run the WebGL 2.0 conformance suite, since these are the places
most likely to break these tests.

(These tests will be run by default on the commit queue as soon as there
is machine capacity to do so.)

BUG=295792
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=thakis@chromium.org
==========

to

==========
Run WebGL 2.0 conformance tests in more cases.

Use CQ_INCLUDE_TRYBOTS directive to run optional GPU tests, which
include the WebGL 2.0 conformance tests, on the commit queue during
ANGLE rolls. Add a script for rolling the WebGL conformance suite and do
the same then.

Add presubmit checks for the gpu/ directory and the Blink WebGL sources
which run the WebGL 2.0 conformance suite, since these are the places
most likely to break these tests.

(These tests will be run by default on the commit queue as soon as there
is machine capacity to do so.)

BUG=295792
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=thakis@chromium.org
==========

[commit-bot: I haz the power, 2016-02-09 04:37:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-09 04:40:08]

Description was changed from

==========
Run WebGL 2.0 conformance tests in more cases.

Use CQ_INCLUDE_TRYBOTS directive to run optional GPU tests, which
include the WebGL 2.0 conformance tests, on the commit queue during
ANGLE rolls. Add a script for rolling the WebGL conformance suite and do
the same then.

Add presubmit checks for the gpu/ directory and the Blink WebGL sources
which run the WebGL 2.0 conformance suite, since these are the places
most likely to break these tests.

(These tests will be run by default on the commit queue as soon as there
is machine capacity to do so.)

BUG=295792
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=thakis@chromium.org
==========

to

==========
Run WebGL 2.0 conformance tests in more cases.

Use CQ_INCLUDE_TRYBOTS directive to run optional GPU tests, which
include the WebGL 2.0 conformance tests, on the commit queue during
ANGLE rolls. Add a script for rolling the WebGL conformance suite and do
the same then.

Add presubmit checks for the gpu/ directory and the Blink WebGL sources
which run the WebGL 2.0 conformance suite, since these are the places
most likely to break these tests.

(These tests will be run by default on the commit queue as soon as there
is machine capacity to do so.)

BUG=295792
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=thakis@chromium.org

Committed: https://crrev.com/e85ee566e1458ec56cb0fd6ca0c5c081c6d6d485
Cr-Commit-Position: refs/heads/master@{#374307}
==========

[commit-bot: I haz the power, 2016-02-09 04:40:10]

Patchset 2 (id:??) landed as
https://crrev.com/e85ee566e1458ec56cb0fd6ca0c5c081c6d6d485
Cr-Commit-Position: refs/heads/master@{#374307}

[kjellander_chromium, 2016-02-09 08:29:28]

On 2016/02/09 01:23:14, Nico wrote:
> Is it possible to make this less copy-pasta-y? When I wanted to land a similar
> script for pdfium in https://codereview.chromium.org/1289873005/ , kjellander
> and agable both told me not to do that (with the effect of me ferrying the
> script around locally, which isn't the best outcome either :-P)
> 
> Anyhoo, owners lgtm

...and the roll scripts are taking over :)

I actually offered to help reducing the code duplication in
https://codereview.chromium.org/1289873005/. I mostly wanted to hear the infra
team's input on that review. I think the goal of our roll scripts in src/tools
and the roll_dep.py script in depot tools are a bit different (as you already
mentioned in the review: it doesn't do any of the branch handling etc).

IMHO, I think it's fine to use roll_dep/roll_dep_svn in scripts in src/tools.
Since different projects will always have their own special needs (different
roll-CL descriptions, additional trybots to run etc), I think the scripts should
be put in Chromium src/tools, not depot tools.

That said, we could still probably create a roll_lib.py and break out some of
the duplicated code in there (which is what I offered to help with). I filed
http://crbug.com/585360 to track this, but I can't make promises that I'll
allocate much time for it. I'll see if I can at least do a small piece now.

[Jamie Madill, 2016-02-09 13:23:17]

On 2016/02/09 08:29:28, kjellander (chromium) wrote:
> On 2016/02/09 01:23:14, Nico wrote:
> > Is it possible to make this less copy-pasta-y? When I wanted to land a
similar
> > script for pdfium in https://codereview.chromium.org/1289873005/ ,
kjellander
> > and agable both told me not to do that (with the effect of me ferrying the
> > script around locally, which isn't the best outcome either :-P)
> > 
> > Anyhoo, owners lgtm
> 
> ...and the roll scripts are taking over :)
> 
> I actually offered to help reducing the code duplication in
> https://codereview.chromium.org/1289873005/. I mostly wanted to hear the infra
> team's input on that review. I think the goal of our roll scripts in src/tools
> and the roll_dep.py script in depot tools are a bit different (as you already
> mentioned in the review: it doesn't do any of the branch handling etc).
> 
> IMHO, I think it's fine to use roll_dep/roll_dep_svn in scripts in src/tools.
> Since different projects will always have their own special needs (different
> roll-CL descriptions, additional trybots to run etc), I think the scripts
should
> be put in Chromium src/tools, not depot tools.
> 
> That said, we could still probably create a roll_lib.py and break out some of
> the duplicated code in there (which is what I offered to help with). I filed
> http://crbug.com/585360 to track this, but I can't make promises that I'll
> allocate much time for it. I'll see if I can at least do a small piece now.

Per discussion in other thread... we were holding off on including win_clang_dbg
as a required bot for ANGLE rolls because of the 4h15m cycle time.

[Zhenyao Mo, 2016-02-09 17:34:14]

lgtm after the fact.  This is great progress!

[bajones, 2016-02-09 17:44:50]

On 2016/02/09 17:34:14, Zhenyao Mo wrote:
> lgtm after the fact.  This is great progress!

Post-commit LGTM here as well. This is awesome!