Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1865873002: Simplify IC interfaces (Closed)

Created:
4 years, 8 months ago by Toon Verwaest
Modified:
4 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify IC interfaces BUG= Committed: https://crrev.com/911a5768dcf7bc8a5cbfb8fca9a7e887af42296f Cr-Commit-Position: refs/heads/master@{#35301}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -100 lines) Patch
M src/code-factory.cc View 5 chunks +10 lines, -13 lines 0 comments Download
M src/ic/ic.h View 5 chunks +0 lines, -14 lines 0 comments Download
M src/ic/ic.cc View 4 chunks +6 lines, -67 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Toon Verwaest
ptal
4 years, 8 months ago (2016-04-06 12:28:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865873002/1
4 years, 8 months ago (2016-04-06 12:32:30 UTC) #4
mvstanton
lgtm
4 years, 8 months ago (2016-04-06 12:33:24 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 12:56:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865873002/1
4 years, 8 months ago (2016-04-06 13:17:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865873002/1
4 years, 8 months ago (2016-04-06 13:29:01 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 13:37:00 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 13:38:41 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/911a5768dcf7bc8a5cbfb8fca9a7e887af42296f
Cr-Commit-Position: refs/heads/master@{#35301}

Powered by Google App Engine
This is Rietveld 408576698