Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: src/code-factory.cc

Issue 1865873002: Simplify IC interfaces (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ic/ic.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-factory.cc
diff --git a/src/code-factory.cc b/src/code-factory.cc
index 6a9c18536168cc8a8f82e257445965c45854516e..9b6ac55c123ec4b338431edce98789b4afbdf2a9 100644
--- a/src/code-factory.cc
+++ b/src/code-factory.cc
@@ -13,9 +13,8 @@ namespace internal {
// static
Callable CodeFactory::LoadIC(Isolate* isolate, TypeofMode typeof_mode) {
- return Callable(LoadIC::initialize_stub(
- isolate, LoadICState(typeof_mode).GetExtraICState()),
- LoadDescriptor(isolate));
+ LoadICTrampolineStub stub(isolate, LoadICState(typeof_mode));
+ return Callable(stub.GetCode(), LoadDescriptor(isolate));
}
@@ -32,8 +31,8 @@ Callable CodeFactory::LoadICInOptimizedCode(
// static
Callable CodeFactory::KeyedLoadIC(Isolate* isolate) {
- return Callable(KeyedLoadIC::initialize_stub(isolate, kNoExtraICState),
- LoadDescriptor(isolate));
+ KeyedLoadICTrampolineStub stub(isolate, LoadICState(kNoExtraICState));
+ return Callable(stub.GetCode(), LoadDescriptor(isolate));
}
@@ -53,8 +52,8 @@ Callable CodeFactory::KeyedLoadICInOptimizedCode(
Callable CodeFactory::CallIC(Isolate* isolate, int argc,
ConvertReceiverMode mode,
TailCallMode tail_call_mode) {
- return Callable(CallIC::initialize_stub(isolate, argc, mode, tail_call_mode),
- CallFunctionWithFeedbackDescriptor(isolate));
+ CallICTrampolineStub stub(isolate, CallICState(argc, mode, tail_call_mode));
+ return Callable(stub.GetCode(), CallFunctionWithFeedbackDescriptor(isolate));
}
@@ -70,9 +69,8 @@ Callable CodeFactory::CallICInOptimizedCode(Isolate* isolate, int argc,
// static
Callable CodeFactory::StoreIC(Isolate* isolate, LanguageMode language_mode) {
- return Callable(
- StoreIC::initialize_stub(isolate, language_mode, UNINITIALIZED),
- VectorStoreICTrampolineDescriptor(isolate));
+ VectorStoreICTrampolineStub stub(isolate, StoreICState(language_mode));
+ return Callable(stub.GetCode(), VectorStoreICTrampolineDescriptor(isolate));
}
@@ -92,9 +90,8 @@ Callable CodeFactory::StoreICInOptimizedCode(
// static
Callable CodeFactory::KeyedStoreIC(Isolate* isolate,
LanguageMode language_mode) {
- return Callable(
- KeyedStoreIC::initialize_stub(isolate, language_mode, UNINITIALIZED),
- VectorStoreICTrampolineDescriptor(isolate));
+ VectorKeyedStoreICTrampolineStub stub(isolate, StoreICState(language_mode));
+ return Callable(stub.GetCode(), VectorStoreICTrampolineDescriptor(isolate));
}
« no previous file with comments | « no previous file | src/ic/ic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698