Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1865603004: Fix crash when setting invalid URL on content (Closed)

Created:
4 years, 8 months ago by alancutter (OOO until 2018)
Modified:
4 years, 8 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash when setting invalid URL on content This change fixes a crash caused by a recent refactor to content style application. This also fixes serialization of invalid image CSS values after multiple style recalcs where previously we should serialize as none instead of the specified URL. BUG=599705 Committed: https://crrev.com/37a62ed4183b7ff3c7711650f580ab3b7973f046 Cr-Commit-Position: refs/heads/master@{#385409}

Patch Set 1 #

Patch Set 2 : pants #

Messages

Total messages: 11 (6 generated)
alancutter (OOO until 2018)
4 years, 8 months ago (2016-04-06 06:52:52 UTC) #2
Timothy Loh
On 2016/04/06 06:52:52, alancutter wrote: lgtm
4 years, 8 months ago (2016-04-06 06:56:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865603004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865603004/20001
4 years, 8 months ago (2016-04-06 06:58:06 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-06 08:58:38 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 09:00:32 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/37a62ed4183b7ff3c7711650f580ab3b7973f046
Cr-Commit-Position: refs/heads/master@{#385409}

Powered by Google App Engine
This is Rietveld 408576698