third_party/WebKit/LayoutTests/css3/images/invalid-image-url-crash.html - Issue 1865603004: Fix crash when setting invalid URL on content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/css3/images/invalid-image-url-crash.html

Issue 1865603004: Fix crash when setting invalid URL on content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pants Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/css3/images/invalid-image-url-crash.html

diff --git a/third_party/WebKit/LayoutTests/css3/images/invalid-image-url-crash.html b/third_party/WebKit/LayoutTests/css3/images/invalid-image-url-crash.html

index 47204ce9a177791475a74538126b9297fa8f291d..caeb532d967baf2be67d8d81027e6a7ea5d7e8cc 100644

--- a/third_party/WebKit/LayoutTests/css3/images/invalid-image-url-crash.html

+++ b/third_party/WebKit/LayoutTests/css3/images/invalid-image-url-crash.html

@@ -1,13 +1,22 @@

<!DOCTYPE html>

+<style>

+#target {

+ background-image: url("chrome://");

+#target:after {

+ content: url("filesystem://");

+</style>

test(() => {

- target.style.backgroundImage = 'url(filesystem://invalid_url.png)';

- // Force multiple style recalcs so that the image gets cached and reused.

+ // Force a second style recalc so that the image gets cached and reused.

getComputedStyle(target).backgroundImage;

+ getComputedStyle(target, 'after').content;

target.style.color = 'green';

getComputedStyle(target).backgroundImage;

+ getComputedStyle(target, 'after').content;

}, "Don't crash when using cached CSS images with invalid URLs");

</script>

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css/getComputedStyle/disallowed-url-serialization.html » ('j') | no next file with comments »