third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp - Issue 1865583002: Implement BaseAudioContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

Issue 1865583002: Implement BaseAudioContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandlerTest.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h » ('j') | third_party/WebKit/Source/modules/webaudio/AudioNode.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp b/third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

index be4f480e8222ba06ca4ec9ebb1a4df839c9072a6..9b71eca151c2309b0c1eb8b6fdf781ecae0b2a9d 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp

@@ -30,7 +30,7 @@

#include "bindings/core/v8/ExceptionMessages.h"

#include "bindings/core/v8/ExceptionState.h"

#include "core/dom/ExceptionCode.h"

-#include "modules/webaudio/AbstractAudioContext.h"

+#include "modules/webaudio/BaseAudioContext.h"

#include "platform/audio/AudioBus.h"

#include "platform/audio/AudioFileReader.h"

#include "platform/audio/AudioUtilities.h"

@@ -40,7 +40,7 @@ namespace blink {

AudioBuffer* AudioBuffer::create(unsigned numberOfChannels, size_t numberOfFrames, float sampleRate)

{

- if (!AudioUtilities::isValidAudioBufferSampleRate(sampleRate) || numberOfChannels > AbstractAudioContext::maxNumberOfChannels() || !numberOfChannels || !numberOfFrames)

+ if (!AudioUtilities::isValidAudioBufferSampleRate(sampleRate) || numberOfChannels > BaseAudioContext::maxNumberOfChannels() || !numberOfChannels || !numberOfFrames)

return nullptr;

AudioBuffer* buffer = new AudioBuffer(numberOfChannels, numberOfFrames, sampleRate);

@@ -52,7 +52,7 @@ AudioBuffer* AudioBuffer::create(unsigned numberOfChannels, size_t numberOfFrame

AudioBuffer* AudioBuffer::create(unsigned numberOfChannels, size_t numberOfFrames, float sampleRate, ExceptionState& exceptionState)

{

- if (!numberOfChannels || numberOfChannels > AbstractAudioContext::maxNumberOfChannels()) {

+ if (!numberOfChannels || numberOfChannels > BaseAudioContext::maxNumberOfChannels()) {

exceptionState.throwDOMException(

NotSupportedError,

ExceptionMessages::indexOutsideRange(

@@ -60,7 +60,7 @@ AudioBuffer* AudioBuffer::create(unsigned numberOfChannels, size_t numberOfFrame

numberOfChannels,

1u,

ExceptionMessages::InclusiveBound,

- AbstractAudioContext::maxNumberOfChannels(),

+ BaseAudioContext::maxNumberOfChannels(),

ExceptionMessages::InclusiveBound));

return nullptr;

}