third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandlerTest.cpp - Issue 1865583002: Implement BaseAudioContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandlerTest.cpp

Issue 1865583002: Implement BaseAudioContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AudioBuffer.cpp » ('j') | third_party/WebKit/Source/modules/webaudio/AudioNode.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandlerTest.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandlerTest.cpp b/third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandlerTest.cpp

index 612c176aaa28038eaff858ae07335598f0ead425..353ff34948e9d3db7f3f10c02b5a740548da88b3 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandlerTest.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandlerTest.cpp

@@ -25,7 +25,7 @@ public:

class MockProcessorNode final : public AudioNode {

public:

- MockProcessorNode(AbstractAudioContext& context)

+ MockProcessorNode(BaseAudioContext& context)

: AudioNode(context)

{

setHandler(AudioBasicProcessorHandler::create(AudioHandler::NodeTypeWaveShaper, *this, 48000, adoptPtr(new MockAudioProcessor())));

@@ -41,7 +41,7 @@ TEST(AudioBasicProcessorHandlerTest, ProcessorFinalization)

AudioBasicProcessorHandler& handler = static_cast<AudioBasicProcessorHandler&>(node->handler());

EXPECT_TRUE(handler.processor());

EXPECT_TRUE(handler.processor()->isInitialized());

- AbstractAudioContext::AutoLocker locker(context);

+ BaseAudioContext::AutoLocker locker(context);

handler.dispose();

// The AudioProcessor should live after dispose() and should not be

// finalized because an audio thread is using it.