Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 1865533002: Add Mojo{Set,Get}DataPipeConsumerOptions() to the standard/native system thunks. (Closed)

Created:
4 years, 8 months ago by viettrungluu
Modified:
4 years, 8 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work786_dp_read_threshold
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add Mojo{Set,Get}DataPipeConsumerOptions() to the standard/native system thunks. * Not yet added for NaCl. * Also add tests. (Note that they have to be fully ifdef-ed out for NaCl and not just disabled, since the thunks don't exist for NaCl yet -- not just unsupported.) R=vardhan@google.com BUG=#442 Committed: https://chromium.googlesource.com/external/mojo/+/57418b2bb4965547dc7a4f99c4d0e2ce05cd0c7f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -13 lines) Patch
M mojo/edk/embedder/entrypoints.cc View 3 chunks +18 lines, -1 line 0 comments Download
M mojo/public/c/system/tests/core_unittest.cc View 12 chunks +136 lines, -12 lines 0 comments Download
M mojo/public/platform/native/system_thunks.h View 2 chunks +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (1 generated)
viettrungluu
(Dependent on https://codereview.chromium.org/1856113002/.)
4 years, 8 months ago (2016-04-05 17:56:01 UTC) #1
vardhan
lgtm
4 years, 8 months ago (2016-04-05 18:38:43 UTC) #2
viettrungluu
4 years, 8 months ago (2016-04-05 19:15:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
57418b2bb4965547dc7a4f99c4d0e2ce05cd0c7f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698