Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1856113002: EDK: Add implementation of data pipe consumer read threshold stuff. (Closed)

Created:
4 years, 8 months ago by viettrungluu
Modified:
4 years, 8 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Add implementation of data pipe consumer read threshold stuff. * Add methods to Core. * ... to Dispatcher. * ... to DataPipeConsumerDispatcher. * ... to DataPipe. * ... to DataPipeImpl. * ... to LocalDataPipeImpl. * ... to RemoteProducerDataPipeImpl. * Add tests. * Don't actually expose the new functions to Mojo programs yet (i.e., no thunks yet). * But the new handle signal is exposed! * Update existing tests (due to new handle signal). R=vardhan@google.com BUG=#442 Committed: https://chromium.googlesource.com/external/mojo/+/afe7672f3020a8b28fdbb316b3f7f91dcdd35ad0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+739 lines, -132 lines) Patch
M mojo/edk/system/core.h View 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/edk/system/core.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M mojo/edk/system/core_unittest.cc View 20 chunks +158 lines, -30 lines 0 comments Download
M mojo/edk/system/data_pipe.h View 3 chunks +12 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.h View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 2 chunks +41 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_impl_unittest.cc View 28 chunks +300 lines, -48 lines 0 comments Download
M mojo/edk/system/dispatcher.h View 4 chunks +13 lines, -0 lines 0 comments Download
M mojo/edk/system/dispatcher.cc View 2 chunks +34 lines, -0 lines 0 comments Download
M mojo/edk/system/dispatcher_unittest.cc View 4 chunks +18 lines, -0 lines 0 comments Download
M mojo/edk/system/local_data_pipe_impl.cc View 1 chunk +16 lines, -5 lines 0 comments Download
M mojo/edk/system/remote_data_pipe_impl_unittest.cc View 8 chunks +20 lines, -10 lines 0 comments Download
M mojo/edk/system/remote_producer_data_pipe_impl.cc View 1 chunk +16 lines, -5 lines 0 comments Download
M mojo/public/c/system/tests/core_unittest.cc View 7 chunks +24 lines, -17 lines 0 comments Download
M mojo/public/platform/native/system_impl_private_unittest.cc View 7 chunks +24 lines, -17 lines 0 comments Download

Dependent Patchsets:

Issue 1865533002 Patch 1

Messages

Total messages: 6 (2 generated)
viettrungluu
4 years, 8 months ago (2016-04-04 20:34:52 UTC) #1
viettrungluu
ping
4 years, 8 months ago (2016-04-05 17:49:30 UTC) #2
vardhan
lgtm
4 years, 8 months ago (2016-04-05 18:33:04 UTC) #4
viettrungluu
4 years, 8 months ago (2016-04-05 19:14:45 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
afe7672f3020a8b28fdbb316b3f7f91dcdd35ad0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698