Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1865303006: Map webRequest filter type to multiple internal ResourceTypes if needed (Closed)

Created:
4 years, 8 months ago by robwu
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Map webRequest filter type to multiple internal ResourceTypes if needed In the past, there was a 1-to-1 relation between content::ResourceType and the public webRequest types. Since https://crbug.com/410382#c39 added multiple resource types that mapped to the same webRequest type, this relation is no longer true (it's now a n-to-1 relation). This change needs to be accounted for by registering multiple internal filter types if a webRequest filter type is set that maps to more than one content::ResourceType. BUG=591988 TEST=browser_tests --gtest_filter=ExtensionWebRequestApiTest.WebRequestTypes Review URL: https://codereview.chromium.org/1853283002 Cr-Commit-Position: refs/heads/master@{#385340} (cherry picked from commit 4bb2b298018be3f9edebe3009d9e7a92f04e06aa) Committed: https://chromium.googlesource.com/chromium/src/+/578357907484815345da27beeeca60cd660272fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -19 lines) Patch
M chrome/test/data/extensions/api_test/webrequest/framework.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/webrequest/test_types.js View 4 chunks +109 lines, -1 line 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc View 1 chunk +1 line, -3 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 1 chunk +1 line, -3 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api_helpers.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api_helpers.cc View 3 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
robwu
4 years, 8 months ago (2016-04-08 16:40:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
578357907484815345da27beeeca60cd660272fb.

Powered by Google App Engine
This is Rietveld 408576698