Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 1853283002: Map webRequest filter type to multiple internal ResourceTypes if needed (Closed)

Created:
4 years, 8 months ago by robwu
Modified:
4 years, 8 months ago
Reviewers:
Finnur, battre
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Map webRequest filter type to multiple internal ResourceTypes if needed In the past, there was a 1-to-1 relation between content::ResourceType and the public webRequest types. Since https://crbug.com/410382#c39 added multiple resource types that mapped to the same webRequest type, this relation is no longer true (it's now a n-to-1 relation). This change needs to be accounted for by registering multiple internal filter types if a webRequest filter type is set that maps to more than one content::ResourceType. BUG=591988 TEST=browser_tests --gtest_filter=ExtensionWebRequestApiTest.WebRequestTypes Committed: https://crrev.com/4bb2b298018be3f9edebe3009d9e7a92f04e06aa Cr-Commit-Position: refs/heads/master@{#385340}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -19 lines) Patch
M chrome/test/data/extensions/api_test/webrequest/framework.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/webrequest/test_types.js View 4 chunks +109 lines, -1 line 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc View 1 chunk +1 line, -3 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 1 chunk +1 line, -3 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api_helpers.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api_helpers.cc View 3 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
robwu
4 years, 8 months ago (2016-04-04 21:45:58 UTC) #2
battre
lgtm
4 years, 8 months ago (2016-04-05 09:25:24 UTC) #3
robwu
+Finnur, please rubberstamp this CL (extensions/).
4 years, 8 months ago (2016-04-05 09:28:15 UTC) #5
Finnur
rubberstamp LGTM on extensions/*
4 years, 8 months ago (2016-04-05 15:10:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853283002/1
4 years, 8 months ago (2016-04-05 19:29:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/205964)
4 years, 8 months ago (2016-04-05 22:40:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853283002/1
4 years, 8 months ago (2016-04-05 22:51:47 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 00:18:17 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 00:19:56 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4bb2b298018be3f9edebe3009d9e7a92f04e06aa
Cr-Commit-Position: refs/heads/master@{#385340}

Powered by Google App Engine
This is Rietveld 408576698