Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 18653: Irregexp-ia32: Fixes register misuse in frame-align code that fails on Mac. (Closed)

Created:
11 years, 11 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Irregexp-32 frame-align code uses a register. This is no longer hard-coded to ebx.

Patch Set 1 #

Patch Set 2 : Now using the register argument. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M src/regexp-macro-assembler-ia32.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/regexp-macro-assembler-ia32.cc View 1 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
Quick review.
11 years, 11 months ago (2009-01-22 08:58:55 UTC) #1
Mads Ager (chromium)
11 years, 11 months ago (2009-01-22 09:00:50 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698