Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/regexp-macro-assembler-ia32.h

Issue 18653: Irregexp-ia32: Fixes register misuse in frame-align code that fails on Mac. (Closed)
Patch Set: Now using the register argument. Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/regexp-macro-assembler-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 212
213 // Pops a value from the backtrack stack. Reads the word at the stack pointer 213 // Pops a value from the backtrack stack. Reads the word at the stack pointer
214 // (ecx) and increments it by a word size. 214 // (ecx) and increments it by a word size.
215 inline void Pop(Register target); 215 inline void Pop(Register target);
216 216
217 // Before calling a C-function from generated code, align arguments on stack. 217 // Before calling a C-function from generated code, align arguments on stack.
218 // After aligning the frame, arguments must be stored in esp[0], esp[4], 218 // After aligning the frame, arguments must be stored in esp[0], esp[4],
219 // etc., not pushed. The argument count assumes all arguments are word sized. 219 // etc., not pushed. The argument count assumes all arguments are word sized.
220 // Some compilers/platforms require the stack to be aligned when calling 220 // Some compilers/platforms require the stack to be aligned when calling
221 // C++ code. 221 // C++ code.
222 inline void FrameAlign(int num_arguments); 222 // Needs a scratch register to do some arithmetic. This register will be
223 // trashed.
224 inline void FrameAlign(int num_arguments, Register scratch);
223 225
224 // Calls a C function and cleans up the space for arguments allocated 226 // Calls a C function and cleans up the space for arguments allocated
225 // by FrameAlign. The called function is not allowed to trigger a garbage 227 // by FrameAlign. The called function is not allowed to trigger a garbage
226 // collection, since that might move the code and invalidate the return 228 // collection, since that might move the code and invalidate the return
227 // address (unless this is somehow accounted for). 229 // address (unless this is somehow accounted for).
228 inline void CallCFunction(Address function_address, int num_arguments); 230 inline void CallCFunction(Address function_address, int num_arguments);
229 231
230 MacroAssembler* masm_; 232 MacroAssembler* masm_;
231 233
232 // Constant buffer provider. Allocates external storage for storing 234 // Constant buffer provider. Allocates external storage for storing
(...skipping 19 matching lines...) Expand all
252 Label check_preempt_label_; 254 Label check_preempt_label_;
253 Label stack_overflow_label_; 255 Label stack_overflow_label_;
254 256
255 // Handle used to represent the generated code object itself. 257 // Handle used to represent the generated code object itself.
256 Handle<Object> self_; 258 Handle<Object> self_;
257 }; 259 };
258 260
259 }} // namespace v8::internal 261 }} // namespace v8::internal
260 262
261 #endif /* REGEXP_MACRO_ASSEMBLER_IA32_H_ */ 263 #endif /* REGEXP_MACRO_ASSEMBLER_IA32_H_ */
OLDNEW
« no previous file with comments | « no previous file | src/regexp-macro-assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698