Chromium Code Reviews
DescriptionRevert of Tab/Desktop Capture: Use requests instead of timer-based refreshing. (patchset #3 id:40001 of https://codereview.chromium.org/1864813002/ )
Reason for revert:
This has caused > 50 tryjobs to flake so far
BUG=601308
Original issue's description:
> Tab/Desktop Capture: Use requests instead of timer-based refreshing.
>
> Remove the long-standing, hacky timer-based frame capture mechanisms
> from the tab (and Desktop-on-Aura) capture implementations. Instead,
> downstream consumers will now make refresh frame requests when needed,
> and at the desired frequency for their specific use cases.
>
> This change depends on https://codereview.chromium.org/1849003002/.
>
> Also: 1) Deleted support implementation for the timer mechanisms from
> SmoothEventSampler, 2) updated WCVCD unit tests to only expect frames
> when explicitly requested, and 3) the NotificationCenter mechanism was
> removed from the WCVCD unit tests because it was removed from the impl
> long ago (but the unit tests were erroneously passing due to the timer
> refreshes).
>
> BUG=486274
>
> Committed: https://crrev.com/e3d466694d3a14958b478408577158c4c6804fe4
> Cr-Commit-Position: refs/heads/master@{#385668}
TBR=xjz@chromium.org,isheriff@chromium.org,mcasas@chromium.org,miu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=486274
Patch Set 1 #Messages
Total messages: 8 (3 generated)
|