Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1865283003: Revert of Tab/Desktop Capture: Use requests instead of timer-based refreshing. (Closed)

Created:
4 years, 8 months ago by jam
Modified:
4 years, 8 months ago
Reviewers:
xjz, Irfan, miu, mcasas
CC:
chromium-reviews, posciak+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@video_refresh_from_sinks
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Tab/Desktop Capture: Use requests instead of timer-based refreshing. (patchset #3 id:40001 of https://codereview.chromium.org/1864813002/ ) Reason for revert: This has caused > 50 tryjobs to flake so far BUG=601308 Original issue's description: > Tab/Desktop Capture: Use requests instead of timer-based refreshing. > > Remove the long-standing, hacky timer-based frame capture mechanisms > from the tab (and Desktop-on-Aura) capture implementations. Instead, > downstream consumers will now make refresh frame requests when needed, > and at the desired frequency for their specific use cases. > > This change depends on https://codereview.chromium.org/1849003002/. > > Also: 1) Deleted support implementation for the timer mechanisms from > SmoothEventSampler, 2) updated WCVCD unit tests to only expect frames > when explicitly requested, and 3) the NotificationCenter mechanism was > removed from the WCVCD unit tests because it was removed from the impl > long ago (but the unit tests were erroneously passing due to the timer > refreshes). > > BUG=486274 > > Committed: https://crrev.com/e3d466694d3a14958b478408577158c4c6804fe4 > Cr-Commit-Position: refs/heads/master@{#385668} TBR=xjz@chromium.org,isheriff@chromium.org,mcasas@chromium.org,miu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=486274

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+398 lines, -423 lines) Patch
M content/browser/media/capture/aura_window_capture_machine.h View 4 chunks +5 lines, -2 lines 0 comments Download
M content/browser/media/capture/aura_window_capture_machine.cc View 5 chunks +14 lines, -6 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device.cc View 12 chunks +19 lines, -38 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 23 chunks +108 lines, -160 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_buffer_pool.cc View 1 chunk +1 line, -3 lines 0 comments Download
M media/capture/content/screen_capture_device_core.h View 2 chunks +0 lines, -13 lines 0 comments Download
M media/capture/content/screen_capture_device_core.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M media/capture/content/smooth_event_sampler.h View 2 chunks +15 lines, -1 line 0 comments Download
M media/capture/content/smooth_event_sampler.cc View 2 chunks +27 lines, -3 lines 0 comments Download
M media/capture/content/smooth_event_sampler_unittest.cc View 18 chunks +101 lines, -10 lines 0 comments Download
M media/capture/content/thread_safe_capture_oracle.h View 1 chunk +0 lines, -15 lines 0 comments Download
M media/capture/content/thread_safe_capture_oracle.cc View 4 chunks +54 lines, -88 lines 0 comments Download
M media/capture/content/video_capture_oracle.h View 2 chunks +8 lines, -6 lines 0 comments Download
M media/capture/content/video_capture_oracle.cc View 5 chunks +24 lines, -39 lines 0 comments Download
M media/capture/content/video_capture_oracle_unittest.cc View 3 chunks +22 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jam
Created Revert of Tab/Desktop Capture: Use requests instead of timer-based refreshing.
4 years, 8 months ago (2016-04-07 21:46:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865283003/1
4 years, 8 months ago (2016-04-07 21:47:13 UTC) #3
jam
On 2016/04/07 21:46:36, jam wrote: > Created Revert of Tab/Desktop Capture: Use requests instead of ...
4 years, 8 months ago (2016-04-07 21:47:43 UTC) #5
miu
Nononono! You just broke the build again. This was fixed in: https://codereview.chromium.org/1871663002/
4 years, 8 months ago (2016-04-07 21:48:29 UTC) #6
miu
4 years, 8 months ago (2016-04-07 21:49:03 UTC) #7
On 2016/04/07 21:48:29, miu wrote:
> Nononono!  You just broke the build again.  This was fixed in:
> https://codereview.chromium.org/1871663002/

Ah, ok.  We're good!  :)

Powered by Google App Engine
This is Rietveld 408576698