Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: media/capture/content/screen_capture_device_core.h

Issue 1865283003: Revert of Tab/Desktop Capture: Use requests instead of timer-based refreshing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@video_refresh_from_sinks
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/content/screen_capture_device_core.h
diff --git a/media/capture/content/screen_capture_device_core.h b/media/capture/content/screen_capture_device_core.h
index 057e89459e5f784f1fe71d4ca966bb08a40f6edb..7e301545c96060202c23eba2e8a2c5ef96809516 100644
--- a/media/capture/content/screen_capture_device_core.h
+++ b/media/capture/content/screen_capture_device_core.h
@@ -46,18 +46,6 @@
// overloading or under-utilization.
virtual bool IsAutoThrottlingEnabled() const;
- // Called by ScreenCaptureDeviceCore when it failed to satisfy a "refresh
- // frame" request by attempting to resurrect the last video frame from the
- // buffer pool (this is referred to as the "passive" refresh approach). The
- // failure can happen for a number of reasons (e.g., the oracle decided to
- // change resolution, or consumers of the last video frame are not yet
- // finished with it).
- //
- // The implementation of this method should consult the oracle, using the
- // kActiveRefreshRequest event type, to decide whether to initiate a new frame
- // capture, and then do so if the oracle agrees.
- virtual void MaybeCaptureForRefresh() = 0;
-
private:
DISALLOW_COPY_AND_ASSIGN(VideoCaptureMachine);
};
@@ -81,7 +69,6 @@
// Asynchronous requests to change ScreenCaptureDeviceCore state.
void AllocateAndStart(const VideoCaptureParams& params,
scoped_ptr<VideoCaptureDevice::Client> client);
- void RequestRefreshFrame();
void StopAndDeAllocate();
private:
« no previous file with comments | « content/browser/renderer_host/media/video_capture_buffer_pool.cc ('k') | media/capture/content/screen_capture_device_core.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698