chrome/browser/ui/views/settings_api_bubble_helper_views.cc - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/settings_api_bubble_helper_views.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/session_crashed_bubble_view.cc ('k') | chrome/browser/ui/views/ssl_client_certificate_selector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/settings_api_bubble_helper_views.cc

diff --git a/chrome/browser/ui/views/settings_api_bubble_helper_views.cc b/chrome/browser/ui/views/settings_api_bubble_helper_views.cc

index be6ff12e14ae20f836675c02b911ab77a4c13c11..b2be51e342402cd22d03267b8bb512cd100bcca9 100644

--- a/chrome/browser/ui/views/settings_api_bubble_helper_views.cc

+++ b/chrome/browser/ui/views/settings_api_bubble_helper_views.cc

@@ -30,7 +30,7 @@ void ShowSettingsApiBubble(SettingsApiOverrideType type,

Browser* browser,

views::View* anchor_view,

views::BubbleBorder::Arrow arrow) {

- scoped_ptr<ExtensionMessageBubbleController> settings_api_bubble(

+ std::unique_ptr<ExtensionMessageBubbleController> settings_api_bubble(

new ExtensionMessageBubbleController(

new SettingsApiBubbleDelegate(browser->profile(), type), browser));

if (!settings_api_bubble->ShouldShow())

@@ -101,7 +101,7 @@ void MaybeShowExtensionControlledNewTabPage(

if (ntp_url != active_url)

return; // Not being overridden by an extension.

- scoped_ptr<ExtensionMessageBubbleController> ntp_overridden_bubble(

+ std::unique_ptr<ExtensionMessageBubbleController> ntp_overridden_bubble(

new ExtensionMessageBubbleController(

new NtpOverriddenBubbleDelegate(browser->profile()), browser));

if (!ntp_overridden_bubble->ShouldShow())