chrome/browser/ui/views/session_crashed_bubble_view.cc - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/session_crashed_bubble_view.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/session_crashed_bubble_view.h ('k') | chrome/browser/ui/views/settings_api_bubble_helper_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/session_crashed_bubble_view.cc

diff --git a/chrome/browser/ui/views/session_crashed_bubble_view.cc b/chrome/browser/ui/views/session_crashed_bubble_view.cc

index bd75757fd85722a1c3fc9a37557536bd94a34040..166da0f8ccb7ab5bbf542582f553a4fdd810eb1e 100644

--- a/chrome/browser/ui/views/session_crashed_bubble_view.cc

+++ b/chrome/browser/ui/views/session_crashed_bubble_view.cc

@@ -153,8 +153,9 @@ bool SessionCrashedBubble::Show(Browser* browser) {

return true;

// Observes browser removal event and will be deallocated in ShowForReal.

- scoped_ptr<SessionCrashedBubbleView::BrowserRemovalObserver> browser_observer(

- new SessionCrashedBubbleView::BrowserRemovalObserver(browser));

+ std::unique_ptr<SessionCrashedBubbleView::BrowserRemovalObserver>

+ browser_observer(

+ new SessionCrashedBubbleView::BrowserRemovalObserver(browser));

// Stats collection only applies to Google Chrome builds.

#if defined(GOOGLE_CHROME_BUILD)

@@ -176,7 +177,7 @@ bool SessionCrashedBubble::Show(Browser* browser) {

// static

void SessionCrashedBubbleView::ShowForReal(

- scoped_ptr<BrowserRemovalObserver> browser_observer,

+ std::unique_ptr<BrowserRemovalObserver> browser_observer,

bool uma_opted_in_already) {

// Determine whether or not the UMA opt-in option should be offered. It is

// offered only when it is a Google chrome build, user hasn't opted in yet,