chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc ('k') | chrome/browser/ui/views/apps/chrome_native_app_window_views.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h b/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h

index 1b20036b0f27eb930ed6d722483f37464293aad5..dacdb70e496658408dabb4ad506cc71df8dc1795 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h

@@ -7,8 +7,9 @@

#include <stdint.h>

+#include <memory>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/memory/weak_ptr.h"

#include "chrome/browser/ui/views/apps/app_info_dialog/app_info_panel.h"

#include "extensions/common/constants.h"

@@ -82,7 +83,7 @@ class AppInfoSummaryPanel : public AppInfoPanel,

views::Link* homepage_link_;

views::Link* licenses_link_;

- scoped_ptr<LaunchOptionsComboboxModel> launch_options_combobox_model_;

+ std::unique_ptr<LaunchOptionsComboboxModel> launch_options_combobox_model_;

views::Combobox* launch_options_combobox_;

base::WeakPtrFactory<AppInfoSummaryPanel> weak_ptr_factory_;