chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc ('k') | chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc

index 7ebe9d857d31df13fefcdee88a87d210db4730bd..04de888cbe1c055936ef907504f793b07b37fa4b 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc

@@ -4,11 +4,11 @@

#include "chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.h"

+#include <memory>

#include <utility>

#include "apps/saved_files_service.h"

#include "base/callback.h"

-#include "base/memory/scoped_ptr.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/test_extension_system.h"

@@ -39,7 +39,7 @@ class AppInfoPermissionsPanelTest : public testing::Test {

protected:

AppInfoPermissionsPanelTest() {}

- scoped_ptr<base::DictionaryValue> ValidAppManifest() {

+ std::unique_ptr<base::DictionaryValue> ValidAppManifest() {

return extensions::DictionaryBuilder()

.Set("name", "Test App Name")

.Set("version", "2.0")