chrome/browser/ui/extensions/extension_message_bubble_factory.h - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_message_bubble_factory.h

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/extensions/extension_message_bubble_browsertest.h ('k') | chrome/browser/ui/extensions/extension_message_bubble_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/extension_message_bubble_factory.h

diff --git a/chrome/browser/ui/extensions/extension_message_bubble_factory.h b/chrome/browser/ui/extensions/extension_message_bubble_factory.h

index af724e2b87247bf38e3a7150c83d8740161afe1f..771b9c33a64239168c5bcbbd01b925dda943bcd9 100644

--- a/chrome/browser/ui/extensions/extension_message_bubble_factory.h

+++ b/chrome/browser/ui/extensions/extension_message_bubble_factory.h

@@ -5,8 +5,9 @@

#ifndef CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_FACTORY_H_

#define CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_MESSAGE_BUBBLE_FACTORY_H_

+#include <memory>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

class Browser;

@@ -30,7 +31,7 @@ class ExtensionMessageBubbleFactory {

~ExtensionMessageBubbleFactory();

// Returns the controller for the bubble that should be shown, if any.

- scoped_ptr<extensions::ExtensionMessageBubbleController> GetController();

+ std::unique_ptr<extensions::ExtensionMessageBubbleController> GetController();

// Overrides the default behavior for testing.

static void set_override_for_tests(OverrideForTesting override);