chrome/browser/ui/extensions/extension_message_bubble_factory.cc - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_message_bubble_factory.cc

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/extensions/extension_message_bubble_factory.h ('k') | chrome/browser/ui/extensions/icon_with_badge_image_source.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/extension_message_bubble_factory.cc

diff --git a/chrome/browser/ui/extensions/extension_message_bubble_factory.cc b/chrome/browser/ui/extensions/extension_message_bubble_factory.cc

index c461bce72a47ab0d20b272a0ad5424795db6b23e..79b657b3be1d64486fe9ae49bc920a367673f73e 100644

--- a/chrome/browser/ui/extensions/extension_message_bubble_factory.cc

+++ b/chrome/browser/ui/extensions/extension_message_bubble_factory.cc

@@ -102,14 +102,14 @@ ExtensionMessageBubbleFactory::ExtensionMessageBubbleFactory(Browser* browser)

ExtensionMessageBubbleFactory::~ExtensionMessageBubbleFactory() {

}

-scoped_ptr<extensions::ExtensionMessageBubbleController>

+std::unique_ptr<extensions::ExtensionMessageBubbleController>

ExtensionMessageBubbleFactory::GetController() {

Profile* original_profile = browser_->profile()->GetOriginalProfile();

std::set<Profile*>& profiles_evaluated = g_profiles_evaluated.Get();

bool is_initial_check = profiles_evaluated.count(original_profile) == 0;

profiles_evaluated.insert(original_profile);

- scoped_ptr<extensions::ExtensionMessageBubbleController> controller;

+ std::unique_ptr<extensions::ExtensionMessageBubbleController> controller;

if (g_override_for_testing == OVERRIDE_DISABLED)

return controller;