chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell_unittest.mm ('k') | chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h

index a98a2d963d4c6d1211d4d6a8953b4ebc034e6e5a..5d6c1b422f5e7d3001230cf91fe973da7ffad70e 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h

@@ -8,9 +8,10 @@

#import <Cocoa/Cocoa.h>

#include <stddef.h>

+#include <memory>

#include "base/mac/scoped_nsobject.h"

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#import "chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h"

#include "components/omnibox/browser/autocomplete_match.h"

#include "components/omnibox/browser/omnibox_popup_view.h"

@@ -74,7 +75,7 @@ class OmniboxPopupViewMac : public OmniboxPopupView,

void OpenURLForRow(size_t row, WindowOpenDisposition disposition);

OmniboxView* omnibox_view_;

- scoped_ptr<OmniboxPopupModel> model_;

+ std::unique_ptr<OmniboxPopupModel> model_;

NSTextField* field_; // owned by tab controller

// Child window containing a matrix which implements the popup.