chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell_unittest.mm - Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell_unittest.mm

Issue 1865213004: Convert //chrome/browser/ui from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.h ('k') | chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell_unittest.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell_unittest.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell_unittest.mm

index 000990d9dda5a08f6492d1d681ac741418be3714..7b28327501c3bcf9760989d84d37d3b906700528 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell_unittest.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell_unittest.mm

@@ -73,7 +73,7 @@ TEST_F(OmniboxPopupCellTest, AnswerStyle) {

"\"t\": \"°F\",\"tt\": 3} ]}} ]}";

NSString* finalString = @"46°F Thu";

- scoped_ptr<base::Value> root(base::JSONReader::Read(weatherJson));

+ std::unique_ptr<base::Value> root(base::JSONReader::Read(weatherJson));

ASSERT_NE(root, nullptr);

base::DictionaryValue* dictionary;

root->GetAsDictionary(&dictionary);