Fix lazy coding in ViaSingletonPictures.

Fix lazy coding in ViaSingletonPictures.

I was using SkRect::MakeLargest() as bounds, which is sort of nutso,
as that clearly is way out of bounds for how big a picture can feasibly
be, i.e. something closer to SkIRect::MakeLargest().

This was causing spurious quick rejects in drawPatch().  I didn't really 
look much deeper to figure out why.  It's easy enough to just feed it the
proper bounds of the entire content.


This means patch_primitive draws correctly in sp-8888 mode.
I also noticed the GM was too small... it clipped off most of its content.
So I've made it larger.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1865143002

Committed: https://skia.googlesource.com/skia/+/11064dfeb49daa64bd4e539284b9a6d1b78d6e5e

[mtklein_C, 2016-04-06 21:30:14]

Description was changed from

==========
Fix lazy coding in ViaSingletonPictures.

I was using SkRect::MakeLargest() as bounds, which is sort of nutso,
as that clearly is way out of bounds for how big a picture can feasibly
be, i.e. something closer to SkIRect::MakeLargest().

This was causing quick rejects in drawPatch().  I didn't really look
much deeper to figure out why.  It's easy enough to just feed it the
proper bounds of the entire content.


This means patch_primitive draws correctly in sp-8888 mode.
I also noticed the GM was too small... it clipped off most of its content.
So I've made it larger.

BUG=skia:
==========

to

==========
Fix lazy coding in ViaSingletonPictures.

I was using SkRect::MakeLargest() as bounds, which is sort of nutso,
as that clearly is way out of bounds for how big a picture can feasibly
be, i.e. something closer to SkIRect::MakeLargest().

This was causing quick rejects in drawPatch().  I didn't really look
much deeper to figure out why.  It's easy enough to just feed it the
proper bounds of the entire content.


This means patch_primitive draws correctly in sp-8888 mode.
I also noticed the GM was too small... it clipped off most of its content.
So I've made it larger.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-04-06 21:46:38]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 21:46:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1865143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1865143002/1

[mtklein_C, 2016-04-06 21:47:03]

Description was changed from

==========
Fix lazy coding in ViaSingletonPictures.

I was using SkRect::MakeLargest() as bounds, which is sort of nutso,
as that clearly is way out of bounds for how big a picture can feasibly
be, i.e. something closer to SkIRect::MakeLargest().

This was causing quick rejects in drawPatch().  I didn't really look
much deeper to figure out why.  It's easy enough to just feed it the
proper bounds of the entire content.


This means patch_primitive draws correctly in sp-8888 mode.
I also noticed the GM was too small... it clipped off most of its content.
So I've made it larger.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fix lazy coding in ViaSingletonPictures.

I was using SkRect::MakeLargest() as bounds, which is sort of nutso,
as that clearly is way out of bounds for how big a picture can feasibly
be, i.e. something closer to SkIRect::MakeLargest().

This was causing spurious quick rejects in drawPatch().  I didn't really 
look much deeper to figure out why.  It's easy enough to just feed it the
proper bounds of the entire content.


This means patch_primitive draws correctly in sp-8888 mode.
I also noticed the GM was too small... it clipped off most of its content.
So I've made it larger.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[commit-bot: I haz the power, 2016-04-06 21:49:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 21:49:54]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[mtklein_C, 2016-04-06 21:52:00]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 21:52:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1865143002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1865143002/20001

[mtklein, 2016-04-06 21:58:14]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-04-06 21:58:15]

lgtm

[mtklein, 2016-04-06 21:58:18]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2016-04-06 21:58:19]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-04-06 21:58:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1865143002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1865143002/20001

[commit-bot: I haz the power, 2016-04-06 22:02:00]

Description was changed from

==========
Fix lazy coding in ViaSingletonPictures.

I was using SkRect::MakeLargest() as bounds, which is sort of nutso,
as that clearly is way out of bounds for how big a picture can feasibly
be, i.e. something closer to SkIRect::MakeLargest().

This was causing spurious quick rejects in drawPatch().  I didn't really 
look much deeper to figure out why.  It's easy enough to just feed it the
proper bounds of the entire content.


This means patch_primitive draws correctly in sp-8888 mode.
I also noticed the GM was too small... it clipped off most of its content.
So I've made it larger.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fix lazy coding in ViaSingletonPictures.

I was using SkRect::MakeLargest() as bounds, which is sort of nutso,
as that clearly is way out of bounds for how big a picture can feasibly
be, i.e. something closer to SkIRect::MakeLargest().

This was causing spurious quick rejects in drawPatch().  I didn't really 
look much deeper to figure out why.  It's easy enough to just feed it the
proper bounds of the entire content.


This means patch_primitive draws correctly in sp-8888 mode.
I also noticed the GM was too small... it clipped off most of its content.
So I've made it larger.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/11064dfeb49daa64bd4e539284b9a6d1b78d6e5e
==========

[commit-bot: I haz the power, 2016-04-06 22:02:01]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/11064dfeb49daa64bd4e539284b9a6d1b78d6e5e