extensions/renderer/dispatcher.cc - Issue 1865103002: Implement ExtensionView based on out-of-process iframes GuestView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/dispatcher.cc

Issue 1865103002: Implement ExtensionView based on out-of-process iframes GuestView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extensionoptions

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/dispatcher.cc

diff --git a/extensions/renderer/dispatcher.cc b/extensions/renderer/dispatcher.cc

index a31eda7eea84987adc2f49c007c735cd924f7ef7..b056f7d74605e62042eec6798408c8d93e60fd46 100644

--- a/extensions/renderer/dispatcher.cc

+++ b/extensions/renderer/dispatcher.cc

@@ -1597,6 +1597,8 @@ void Dispatcher::RequireGuestViewModules(ScriptContext* context) {

module_system->Require("extensionView");

module_system->Require("extensionViewApiMethods");

module_system->Require("extensionViewAttributes");

+ guest_view_required = true;

lazyboy 2016/04/12 18:16:31 Assuming this CL goes in after appview CL, we can

lfg 2016/04/13 18:19:31 Done.

}

// Require WebView.

« no previous file with comments | « chrome/browser/apps/guest_view/extension_view/extension_view_browsertest.cc ('k') | no next file » | no next file with comments »