Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: extensions/renderer/dispatcher.cc

Issue 1865103002: Implement ExtensionView based on out-of-process iframes GuestView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extensionoptions
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/apps/guest_view/extension_view/extension_view_browsertest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/dispatcher.h" 5 #include "extensions/renderer/dispatcher.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <utility> 9 #include <utility>
10 10
(...skipping 1579 matching lines...) Expand 10 before | Expand all | Expand 10 after
1590 module_system->Require("extensionOptionsAttributes"); 1590 module_system->Require("extensionOptionsAttributes");
1591 1591
1592 guest_view_required = true; 1592 guest_view_required = true;
1593 } 1593 }
1594 1594
1595 // Require ExtensionView. 1595 // Require ExtensionView.
1596 if (context->GetAvailability("extensionViewInternal").is_available()) { 1596 if (context->GetAvailability("extensionViewInternal").is_available()) {
1597 module_system->Require("extensionView"); 1597 module_system->Require("extensionView");
1598 module_system->Require("extensionViewApiMethods"); 1598 module_system->Require("extensionViewApiMethods");
1599 module_system->Require("extensionViewAttributes"); 1599 module_system->Require("extensionViewAttributes");
1600
1601 guest_view_required = true;
lazyboy 2016/04/12 18:16:31 Assuming this CL goes in after appview CL, we can
lfg 2016/04/13 18:19:31 Done.
1600 } 1602 }
1601 1603
1602 // Require WebView. 1604 // Require WebView.
1603 if (context->GetAvailability("webViewInternal").is_available()) { 1605 if (context->GetAvailability("webViewInternal").is_available()) {
1604 module_system->Require("webView"); 1606 module_system->Require("webView");
1605 module_system->Require("webViewApiMethods"); 1607 module_system->Require("webViewApiMethods");
1606 module_system->Require("webViewAttributes"); 1608 module_system->Require("webViewAttributes");
1607 if (context->GetAvailability("webViewExperimentalInternal") 1609 if (context->GetAvailability("webViewExperimentalInternal")
1608 .is_available()) { 1610 .is_available()) {
1609 module_system->Require("webViewExperimental"); 1611 module_system->Require("webViewExperimental");
(...skipping 11 matching lines...) Expand all
1621 // The "guestViewDeny" module must always be loaded last. It registers 1623 // The "guestViewDeny" module must always be loaded last. It registers
1622 // error-providing custom elements for the GuestView types that are not 1624 // error-providing custom elements for the GuestView types that are not
1623 // available, and thus all of those types must have been checked and loaded 1625 // available, and thus all of those types must have been checked and loaded
1624 // (or not loaded) beforehand. 1626 // (or not loaded) beforehand.
1625 if (context_type == Feature::BLESSED_EXTENSION_CONTEXT) { 1627 if (context_type == Feature::BLESSED_EXTENSION_CONTEXT) {
1626 module_system->Require("guestViewDeny"); 1628 module_system->Require("guestViewDeny");
1627 } 1629 }
1628 } 1630 }
1629 1631
1630 } // namespace extensions 1632 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/apps/guest_view/extension_view/extension_view_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698