Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1865103002: Implement ExtensionView based on out-of-process iframes GuestView. (Closed)

Created:
4 years, 8 months ago by lfg
Modified:
4 years, 8 months ago
Reviewers:
Devlin, lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, apacible
Base URL:
https://chromium.googlesource.com/chromium/src.git@extensionoptions
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement ExtensionView based on out-of-process iframes GuestView. BUG=601147 Committed: https://crrev.com/4dcc846e30d5a0181cd008ea2c012b7327452412 Cr-Commit-Position: refs/heads/master@{#387037}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M chrome/browser/apps/guest_view/extension_view/extension_view_browsertest.cc View 6 chunks +15 lines, -6 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 2 2 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
lfg
rdevlin.cronin@chromium.org: Please review changes in extensions/ lazyboy@chromium.org: Please review changes in guest_view/
4 years, 8 months ago (2016-04-12 18:07:19 UTC) #2
lazyboy
+apacible@ FYI lgtm https://codereview.chromium.org/1865103002/diff/20001/extensions/renderer/dispatcher.cc File extensions/renderer/dispatcher.cc (right): https://codereview.chromium.org/1865103002/diff/20001/extensions/renderer/dispatcher.cc#newcode1601 extensions/renderer/dispatcher.cc:1601: guest_view_required = true; Assuming this CL ...
4 years, 8 months ago (2016-04-12 18:16:31 UTC) #3
Devlin
lgtm (with lazyboy's comment addressed)
4 years, 8 months ago (2016-04-12 23:07:27 UTC) #4
lfg
https://codereview.chromium.org/1865103002/diff/20001/extensions/renderer/dispatcher.cc File extensions/renderer/dispatcher.cc (right): https://codereview.chromium.org/1865103002/diff/20001/extensions/renderer/dispatcher.cc#newcode1601 extensions/renderer/dispatcher.cc:1601: guest_view_required = true; On 2016/04/12 18:16:31, lazyboy wrote: > ...
4 years, 8 months ago (2016-04-13 18:19:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865103002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865103002/40001
4 years, 8 months ago (2016-04-13 18:20:35 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-13 18:28:13 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 18:29:57 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/4dcc846e30d5a0181cd008ea2c012b7327452412
Cr-Commit-Position: refs/heads/master@{#387037}

Powered by Google App Engine
This is Rietveld 408576698