Issue 18649002: Revert "Fix stack alignment corruption for MinGW32 build"

Issue 18649002: Revert "Fix stack alignment corruption for MinGW32 build" (Closed)

Created:
7 years, 5 months ago by Jakob Kummerow

Modified:
7 years, 5 months ago

Reviewers:
Dmitry Lomov (no reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Fix stack alignment corruption for MinGW32 build" due to compile failures. This reverts r15480. R=dslomov@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15483

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -238 lines)			Patch
M	src/platform-win32.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	test/cctest/test-assembler-ia32.cc	View	1 chunk	+0 lines, -88 lines	0 comments	Download
M	test/cctest/test-assembler-x64.cc	View	2 chunks	+0 lines, -86 lines	0 comments	Download
M	test/cctest/test-platform.cc	View	1 chunk	+0 lines, -60 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

Committed patchset #1 manually as r15483 (presubmit successful).

7 years, 5 months ago (2013-07-03 15:46:03 UTC) #3

Jakob Kummerow

For the record, the failures were: 9>.\test-platform.cc(71) :error C2065: '__asm__' : undeclared identifier 9>.\test-platform.cc(71) :error ...

7 years, 5 months ago (2013-07-03 15:46:47 UTC) #4

Peter Varga

I cannot open this link. Does it fail with MSVC? On 2013/07/03 15:46:47, Jakob wrote: ...

7 years, 5 months ago (2013-07-04 07:12:46 UTC) #5

Jakob Kummerow

7 years, 5 months ago (2013-07-04 17:03:22 UTC) #6

Message was sent while issue was closed.

On 2013/07/04 07:12:46, Peter Varga wrote:
> I cannot open this link. Does it fail with MSVC?
> 
> On 2013/07/03 15:46:47, Jakob wrote:
> > For the record, the failures were:
> > 
> > 9>.\test-platform.cc(71) :error C2065: '__asm__' : undeclared identifier
> > 9>.\test-platform.cc(71) :error C2146: syntax error : missing ';' before
> > identifier '__volatile__'
> > 9>.\test-platform.cc(71) :error C2143: syntax error : missing ')' before ':'
> > 9>.\test-platform.cc(71) :error C2059: syntax error : ')'
> > 9>.\test-platform.cc(71) :error C3861: '__volatile__': identifier not found
> > 
> > Full log:
> >
>
http://build.chromium.org/p/client.v8/builders/V8%252520Win32%252520-%252520d...

Yes, it fails in MSVC. 

Sorry for the broken link; looks like the codereview site double-escapes it for
some reason. I'm not sure how to prevent that. Copy-pasting the link's displayed
text from the email works for me, clicking it does not.
The following link is correct while writing this message; I hope it survives
sending:
http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug%20-%201...
You can also try to paste the unescaped version into your address bar:
http://build.chromium.org/p/client.v8/builders/V8 Win32 - debug -
1/builds/4766/steps/compile/logs/stdio

Expand Messages | Collapse Messages