Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1864843002: Update MagnifierImageFilter to sk_sp (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M bench/MagnifierBench.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fuzz/FilterFuzz.cpp View 1 chunk +3 lines, -2 lines 2 comments Download
M gm/imagemagnifier.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkMagnifierImageFilter.h View 1 chunk +9 lines, -2 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864843002/1
4 years, 8 months ago (2016-04-05 23:29:56 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 23:42:56 UTC) #7
robertphillips
ping
4 years, 8 months ago (2016-04-06 18:22:21 UTC) #8
f(malita)
lgtm https://codereview.chromium.org/1864843002/diff/1/fuzz/FilterFuzz.cpp File fuzz/FilterFuzz.cpp (right): https://codereview.chromium.org/1864843002/diff/1/fuzz/FilterFuzz.cpp#newcode584 fuzz/FilterFuzz.cpp:584: make_image_filter()); Third arg should be nullptr for equivalence ...
4 years, 8 months ago (2016-04-07 13:33:42 UTC) #9
robertphillips
https://codereview.chromium.org/1864843002/diff/1/fuzz/FilterFuzz.cpp File fuzz/FilterFuzz.cpp (right): https://codereview.chromium.org/1864843002/diff/1/fuzz/FilterFuzz.cpp#newcode584 fuzz/FilterFuzz.cpp:584: make_image_filter()); Right - I believe the prior behavior was ...
4 years, 8 months ago (2016-04-07 14:02:05 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864843002/1
4 years, 8 months ago (2016-04-07 14:20:17 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-07 14:30:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864843002/1
4 years, 8 months ago (2016-04-07 14:33:20 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 14:34:20 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/11171f3b66ba6aba561fcaafbc51eaa354b73353

Powered by Google App Engine
This is Rietveld 408576698