Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2429)

Unified Diff: fuzz/FilterFuzz.cpp

Issue 1864843002: Update MagnifierImageFilter to sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « bench/MagnifierBench.cpp ('k') | gm/imagemagnifier.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fuzz/FilterFuzz.cpp
diff --git a/fuzz/FilterFuzz.cpp b/fuzz/FilterFuzz.cpp
index 87653a18bb3418cd53cbe3add419bbfb0a864c53..67eb0b8c47f35b5132f06c7e233366571c58ab77 100644
--- a/fuzz/FilterFuzz.cpp
+++ b/fuzz/FilterFuzz.cpp
@@ -579,8 +579,9 @@ static sk_sp<SkImageFilter> make_image_filter(bool canBeNull) {
make_image_filter());
break;
case MAGNIFIER:
- filter = sk_sp<SkImageFilter>(SkMagnifierImageFilter::Create(make_rect(),
- make_scalar(true)));
+ filter = SkMagnifierImageFilter::Make(make_rect(),
+ make_scalar(true),
+ make_image_filter());
f(malita) 2016/04/07 13:33:42 Third arg should be nullptr for equivalence with e
robertphillips 2016/04/07 14:02:05 Right - I believe the prior behavior was incorrect
break;
case DOWN_SAMPLE:
filter = sk_sp<SkImageFilter>(SkDownSampleImageFilter::Create(make_scalar()));
« no previous file with comments | « bench/MagnifierBench.cpp ('k') | gm/imagemagnifier.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698