chrome/browser/resources/app_list/start_page.html - Issue 186483004: Add a skeleton Start Page to the experimental app list.

Unified Diff: chrome/browser/resources/app_list/start_page.html

Issue 186483004: Add a skeleton Start Page to the experimental app list. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ares_change_experimental_animation

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/app_list/start_page.css ('k') | chrome/browser/ui/app_list/start_page_service.cc » ('j') | chrome/browser/ui/app_list/start_page_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/app_list/start_page.html

diff --git a/chrome/browser/resources/app_list/start_page.html b/chrome/browser/resources/app_list/start_page.html

index e1cc8db25f002781ef24f9b5eb6239aec6a7f436..9f042afabafc26d666a6e58395fe08eb6ec9b67b 100644

--- a/chrome/browser/resources/app_list/start_page.html

+++ b/chrome/browser/resources/app_list/start_page.html

@@ -13,6 +13,9 @@

</head>

+ <div id="logo-wrapper">

+ <img id="logo" src="chrome://app-list/images/2x/google_logo.png">

tapted 2014/03/10 02:41:54 is this the typical way to do it? I think to prope

calamity 2014/03/14 07:50:02 It seems to be the way that the local ntp does it.

xiyuan 2014/03/14 17:00:54 I agree with Trent that we should follow the -webk

I agree with Trent that we should follow the -webkit-image-set approach and probably should use chrome:://theme. The local-ntp way is more like a shortcut way. Also, we should use background-image of a div instead of a <img> whe we can. The local-ntp page is providing logo in that way. The benefits of using background-image is that we have one less DOM node and the image is not draggable or selectable, does not have a default broken placeholder etc. It is preferable than using a <img>.

+ </div>

</body>