chrome/browser/resources/app_list/start_page.html - Issue 186483004: Add a skeleton Start Page to the experimental app list.

Side by Side Diff: chrome/browser/resources/app_list/start_page.html

Issue 186483004: Add a skeleton Start Page to the experimental app list. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ares_change_experimental_animation

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/app_list/start_page.css ('k') | chrome/browser/ui/app_list/start_page_service.cc » ('j') | chrome/browser/ui/app_list/start_page_service.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html i18n-values="dir:textdirection">	2 <html i18n-values="dir:textdirection">

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <link rel="stylesheet" href="chrome://app-list/start_page.css">	5 <link rel="stylesheet" href="chrome://app-list/start_page.css">

6 <script src="chrome://resources/js/load_time_data.js"></script>	6 <script src="chrome://resources/js/load_time_data.js"></script>

7 <script src="chrome://resources/js/cr.js"></script>	7 <script src="chrome://resources/js/cr.js"></script>

8 <script src="chrome://resources/js/cr/event_target.js"></script>	8 <script src="chrome://resources/js/cr/event_target.js"></script>

9 <script src="chrome://resources/js/cr/ui.js"></script>	9 <script src="chrome://resources/js/cr/ui.js"></script>

10 <script src="chrome://resources/js/util.js"></script>	10 <script src="chrome://resources/js/util.js"></script>

11 <script src="chrome://app-list/strings.js"></script>	11 <script src="chrome://app-list/strings.js"></script>

12 <script src="chrome://app-list/start_page.js"></script>	12 <script src="chrome://app-list/start_page.js"></script>

13 </head>	13 </head>

14	14

15 <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize">	15 <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize">

	16 <div id="logo-wrapper">

	17 <img id="logo" src="chrome://app-list/images/2x/google_logo.png">
	tapted 2014/03/10 02:41:54 is this the typical way to do it? I think to prope is this the typical way to do it? I think to properly handle HiDPI you need something like (in CSS) #logo { background-image: -webkit-image-set( url('chrome://app-list/IDR_APP_LIST_SEARCH_PAGE_LOGO') 1x, url('chrome://app-list/IDR_APP_LIST_SEARCH_PAGE_LOGO@2x') 2x); } Then in the .cc use stuff like ui::ScaleFactor scale_factor; std::string uncached_path; webui::ParsePathAndScale(url, &path, &scale_factor); int resource_id = /* map from string -> resource_id / ResourceBundle::GetSharedInstance() .LoadDataResourceBytesForScale(resource_id, scale_factor)); But most things seem to just lean on chrome://theme for this already (i.e. instead of chrome://app-list). Maybe try that? Otherwise you'd need to roll a new handler with the above, similar to what HandleHotwordFilesResourceFilter is doing in start_page_ui.cc already. Also, where is the image (`git add`)? And are there implications re:branding? I don't think we can distribute a google logo with Chromium. Can you instead hook into the instant-extended API? Or, for an initial placeholder perhaps see, e.g., what's done for IDR_APP_LIST_GOOGLE_LOGO_VOICE_SEARCH calamity* 2014/03/14 07:50:02 It seems to be the way that the local ntp does it. Show quoted text On 2014/03/10 02:41:54, tapted wrote: > is this the typical way to do it? I think to properly handle HiDPI you need > something like (in CSS) > > #logo { > background-image: -webkit-image-set( > url('chrome://app-list/IDR_APP_LIST_SEARCH_PAGE_LOGO') 1x, > url('chrome://app-list/IDR_APP_LIST_SEARCH_PAGE_LOGO@2x') 2x); > } > > Then in the .cc use stuff like > > ui::ScaleFactor scale_factor; > std::string uncached_path; > webui::ParsePathAndScale(url, &path, &scale_factor); > int resource_id = /* map from string -> resource_id / > ResourceBundle::GetSharedInstance() > .LoadDataResourceBytesForScale(resource_id, scale_factor)); > > But most things seem to just lean on chrome://theme for this already (i.e. > instead of chrome://app-list). Maybe try that? Otherwise you'd need to roll a > new handler with the above, similar to what HandleHotwordFilesResourceFilter is > doing in start_page_ui.cc already. > It seems to be the way that the local ntp does it. (see chrome-search://local-ntp/local-ntp.html) I don't think that has any issues on the Pixel. Show quoted text > Also, where is the image (`git add`)? And are there implications re:branding? I > don't think we can distribute a google logo with Chromium. Can you instead hook > into the instant-extended API? > This image is already in the chromium codebase for the local ntp (chrome/browser/resources/local_ntp/images/2x). I'm not entirely sure how to do the Instant stuff at the moment and it's definitely out of scope for this CL. Show quoted text > Or, for an initial placeholder perhaps see, e.g., what's done for > IDR_APP_LIST_GOOGLE_LOGO_VOICE_SEARCH xiyuan* 2014/03/14 17:00:54 I agree with Trent that we should follow the -webk Show quoted text On 2014/03/14 07:50:02, calamity wrote: > On 2014/03/10 02:41:54, tapted wrote: > > is this the typical way to do it? I think to properly handle HiDPI you need > > something like (in CSS) > > > > #logo { > > background-image: -webkit-image-set( > > url('chrome://app-list/IDR_APP_LIST_SEARCH_PAGE_LOGO') 1x, > > url('chrome://app-list/IDR_APP_LIST_SEARCH_PAGE_LOGO@2x') 2x); > > } > > > > Then in the .cc use stuff like > > > > ui::ScaleFactor scale_factor; > > std::string uncached_path; > > webui::ParsePathAndScale(url, &path, &scale_factor); > > int resource_id = /* map from string -> resource_id */ > > ResourceBundle::GetSharedInstance() > > .LoadDataResourceBytesForScale(resource_id, scale_factor)); > > > > But most things seem to just lean on chrome://theme for this already (i.e. > > instead of chrome://app-list). Maybe try that? Otherwise you'd need to roll a > > new handler with the above, similar to what HandleHotwordFilesResourceFilter > is > > doing in start_page_ui.cc already. > > > It seems to be the way that the local ntp does it. (see > chrome-search://local-ntp/local-ntp.html) I don't think that has any issues on > the Pixel. > > Also, where is the image (`git add`)? And are there implications re:branding? > I > > don't think we can distribute a google logo with Chromium. Can you instead > hook > > into the instant-extended API? > > > > This image is already in the chromium codebase for the local ntp > (chrome/browser/resources/local_ntp/images/2x). I'm not entirely sure how to do > the Instant stuff at the moment and it's definitely out of scope for this CL. > > Or, for an initial placeholder perhaps see, e.g., what's done for > > IDR_APP_LIST_GOOGLE_LOGO_VOICE_SEARCH > I agree with Trent that we should follow the -webkit-image-set approach and probably should use chrome:://theme. The local-ntp way is more like a shortcut way. Also, we should use background-image of a div instead of a <img> whe we can. The local-ntp page is providing logo in that way. The benefits of using background-image is that we have one less DOM node and the image is not draggable or selectable, does not have a default broken placeholder etc. It is preferable than using a <img>.
	18 </div>

16 <div id="start-page"></div>	19 <div id="start-page"></div>

17 <script src="chrome://resources/js/i18n_template2.js"></script>	20 <script src="chrome://resources/js/i18n_template2.js"></script>

18 </body>	21 </body>

19 </html>	22 </html>

OLD	NEW