Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1864783002: [ios] Signal DidFinishLoad if target URL is invalid. (Closed)

Created:
4 years, 8 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[ios] Signal DidFinishLoad if target URL is invalid. Target URL can be invalid if Reload is called for empty navigation manager. Empty Navigation Manager is a reasonable state when the only pending item was a page with badd SSL cert and user Tapped Go Back. BUG=598047 Review URL: https://codereview.chromium.org/1844363004 Cr-Commit-Position: refs/heads/master@{#385085} (cherry picked from commit 8466be358c11657cb90fe148c10017573e6cabdc) Committed: https://chromium.googlesource.com/chromium/src/+/b527df8f6c0fe8da64f67b58143ee34c4e6133be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Eugene But (OOO till 7-30)
4 years, 8 months ago (2016-04-05 21:48:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b527df8f6c0fe8da64f67b58143ee34c4e6133be.

Powered by Google App Engine
This is Rietveld 408576698