Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 1844363004: [ios] Signal DidFinishLoad if target URL is invalid. (Closed)

Created:
4 years, 8 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Signal DidFinishLoad if target URL is invalid. Target URL can be invalid if Reload is called for empty navigation manager. Empty Navigation Manager is a reasonable state when the only pending item was a page with badd SSL cert and user Tapped Go Back. BUG=598047 Committed: https://crrev.com/8466be358c11657cb90fe148c10017573e6cabdc Cr-Commit-Position: refs/heads/master@{#385085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Eugene But (OOO till 7-30)
4 years, 8 months ago (2016-04-04 22:09:29 UTC) #2
rohitrao (ping after 24h)
lgtm
4 years, 8 months ago (2016-04-05 00:44:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844363004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844363004/1
4 years, 8 months ago (2016-04-05 01:34:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 02:16:08 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 02:17:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8466be358c11657cb90fe148c10017573e6cabdc
Cr-Commit-Position: refs/heads/master@{#385085}

Powered by Google App Engine
This is Rietveld 408576698