Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: runtime/bin/extensions_win.cc

Issue 186473003: Refactor native extension shared library lookup. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add check for loading from http(s): Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/bin/builtin.dart ('K') | « runtime/bin/extensions_macos.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/extensions_win.cc
diff --git a/runtime/bin/extensions_win.cc b/runtime/bin/extensions_win.cc
index 0f764d3b359d4334c6df576e6596b85ba0a3d366..dea586cccab3d172eb969f825c3bdc583e62a946 100644
--- a/runtime/bin/extensions_win.cc
+++ b/runtime/bin/extensions_win.cc
@@ -12,15 +12,8 @@
namespace dart {
namespace bin {
-void* Extensions::LoadExtensionLibrary(const char* library_path,
- const char* extension_name) {
- const char* strings[] = { library_path, "/", extension_name, ".dll", NULL };
- char* library_file = Concatenate(strings);
- wchar_t* unicode_library_file = StringUtils::Utf8ToWide(library_file);
- void* lib_handle = LoadLibraryW(unicode_library_file);
- free(unicode_library_file);
- free(library_file);
- return lib_handle;
+void* Extensions::LoadExtensionLibrary(const char* library_file) {
+ return LoadLibraryW(StringUtils::Utf8ToWide(library_file));
}
void* Extensions::ResolveSymbol(void* lib_handle, const char* symbol) {
« runtime/bin/builtin.dart ('K') | « runtime/bin/extensions_macos.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698