Web MIDI: add RequestMIDISysExPermission to BrowserContext

content/public/browser/browser_context.h

Index: content/public/browser/browser_context.h
diff --git a/content/public/browser/browser_context.h b/content/public/browser/browser_context.h
index 1fb10528968162b284a5f2a9e824f5e2e50854a2..e1632883ca92c9a7f3cbe58cb20457899f2dc44d 100644
--- a/content/public/browser/browser_context.h
+++ b/content/public/browser/browser_context.h
@@ -48,6 +48,11 @@ class CONTENT_EXPORT BrowserContext : public base::SupportsUserData {
   // The second argument is the StoragePartition object for that partition id.
   typedef base::Callback<void(StoragePartition*)> StoragePartitionCallback;
 
+  // Used in RequestMIDISysExPermission(). The first argument is the render
+  // process id, the second one is the render view id, the third one is the
+  // client id, and the last one represents if the request is permitted.
+  typedef base::Callback<void(int, int, int, bool)> MIDISysExPermissionCallback;

[jam, 2013/07/12 00:16:31]

it looks like you're sending the embedder a bunch of values and then expecting
them to pass them back in. it would be simpler if you use currying to
transparently send these parameters back to content. even if chrome also needs
some of them (i.e. rph/rvh), then you can put it in RequestMIDISysExPermission,
and also use currying


nit: convention in content api (which existing method above doesn't follow :( )
is to put the callback typedef right above the method which uses it

[Takashi Toyoshima, 2013/07/12 12:45:49]

Done.

+
   static DownloadManager* GetDownloadManager(BrowserContext* browser_context);
 
   // Returns BrowserContext specific external mount points. It may return NULL
@@ -128,6 +133,15 @@ class CONTENT_EXPORT BrowserContext : public base::SupportsUserData {
           const base::FilePath& partition_path,
           bool in_memory) = 0;
 
+  // Requests a permission to use system exclusive messages in MIDI events.
+  // |callback| will be invoked when the request is resolved.
+  virtual void RequestMIDISysExPermission(

[jam, 2013/07/12 00:16:31]

what is "SysEx"? see style guide re abbreviations

[Takashi Toyoshima, 2013/07/12 12:45:49]

SysEx is a abbreviation of system exclusive messages, but it is used in Web MIDI
API as a parameter name. So, I think using SysEx here is straight-forward way
and consistent with the spec though style guide say don't use well-known
abbreviations. What do you think about this?
FYI, we already use "SysEx" and "sysex" in some parts of Web MIDI related
codebases.

[jam, 2013/07/12 16:06:35]

ok

+      int render_process_id,
+      int render_view_id,
+      int client_id,
+      const GURL& requesting_frame,
+      const MIDISysExPermissionCallback& callback) = 0;
+
   // Returns the resource context.
   virtual ResourceContext* GetResourceContext() = 0;