Web MIDI: add RequestMIDISysExPermission to BrowserContext

content/public/browser/browser_context.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_BROWSER_CONTEXT_H_
 #define CONTENT_PUBLIC_BROWSER_BROWSER_CONTEXT_H_
 
 #include "base/callback_forward.h"
 #include "base/containers/hash_tables.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 30 matching lines @@
 
 // This class holds the context needed for a browsing session.
 // It lives on the UI thread. All these methods must only be called on the UI
 // thread.
 class CONTENT_EXPORT BrowserContext : public base::SupportsUserData {
  public:
   // Used in ForEachStoragePartition(). The first argument is the partition id.
   // The second argument is the StoragePartition object for that partition id.
   typedef base::Callback<void(StoragePartition*)> StoragePartitionCallback;
 
+  // Used in RequestMIDISysExPermission(). The first argument is the render
+  // process id, the second one is the render view id, the third one is the
+  // client id, and the last one represents if the request is permitted.
+  typedef base::Callback<void(int, int, int, bool)> MIDISysExPermissionCallback;

[jam, 2013/07/12 00:16:31]

it looks like you're sending the embedder a bunch of values and then expecting
them to pass them back in. it would be simpler if you use currying to
transparently send these parameters back to content. even if chrome also needs
some of them (i.e. rph/rvh), then you can put it in RequestMIDISysExPermission,
and also use currying


nit: convention in content api (which existing method above doesn't follow :( )
is to put the callback typedef right above the method which uses it

[Takashi Toyoshima, 2013/07/12 12:45:49]

Done.

+
   static DownloadManager* GetDownloadManager(BrowserContext* browser_context);
 
   // Returns BrowserContext specific external mount points. It may return NULL
   // if the context doesn't have any BrowserContext specific external mount
   // points. Currenty, non-NULL value is returned only on ChromeOS.
   static fileapi::ExternalMountPoints* GetMountPoints(BrowserContext* context);
 
   static content::StoragePartition* GetStoragePartition(
       BrowserContext* browser_context, SiteInstance* site_instance);
   static content::StoragePartition* GetStoragePartitionForSite(
@@ skipping 60 matching lines @@
 
   // Returns the request context for media resources associated with this
   // context and renderer process.
   virtual net::URLRequestContextGetter* GetMediaRequestContextForRenderProcess(
       int renderer_child_id) = 0;
   virtual net::URLRequestContextGetter*
       GetMediaRequestContextForStoragePartition(
           const base::FilePath& partition_path,
           bool in_memory) = 0;
 
+  // Requests a permission to use system exclusive messages in MIDI events.
+  // |callback| will be invoked when the request is resolved.
+  virtual void RequestMIDISysExPermission(

[jam, 2013/07/12 00:16:31]

what is "SysEx"? see style guide re abbreviations

[Takashi Toyoshima, 2013/07/12 12:45:49]

SysEx is a abbreviation of system exclusive messages, but it is used in Web MIDI
API as a parameter name. So, I think using SysEx here is straight-forward way
and consistent with the spec though style guide say don't use well-known
abbreviations. What do you think about this?
FYI, we already use "SysEx" and "sysex" in some parts of Web MIDI related
codebases.

[jam, 2013/07/12 16:06:35]

ok

+      int render_process_id,
+      int render_view_id,
+      int client_id,
+      const GURL& requesting_frame,
+      const MIDISysExPermissionCallback& callback) = 0;
+
   // Returns the resource context.
   virtual ResourceContext* GetResourceContext() = 0;
 
   // Returns the DownloadManagerDelegate for this context. This will be called
   // once per context. The embedder owns the delegate and is responsible for
   // ensuring that it outlives DownloadManager. It's valid to return NULL.
   virtual DownloadManagerDelegate* GetDownloadManagerDelegate() = 0;
 
   // Returns the geolocation permission context for this context. It's valid to
   // return NULL, in which case geolocation requests will always be allowed.
@@ skipping 12 matching lines @@
 struct hash<content::BrowserContext*> {
   std::size_t operator()(content::BrowserContext* const& p) const {
     return reinterpret_cast<std::size_t>(p);
   }
 };
 
 }  // namespace BASE_HASH_NAMESPACE
 #endif
 
 #endif  // CONTENT_PUBLIC_BROWSER_BROWSER_CONTEXT_H_