Using data_deps instead of data in BUILD.gn for app list test components

Using data_deps instead of data in BUILD.gn for app list test components.

BUG=NONE

Committed: https://crrev.com/12297f7670a17add801cb420b6c89a98b8d8fd13
Cr-Commit-Position: refs/heads/master@{#385555}

[Dirk Pranke, 2016-04-05 19:52:22]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-04-05 19:52:23]

https://codereview.chromium.org/1864673002/diff/1/ui/app_list/BUILD.gn
File ui/app_list/BUILD.gn (right):

https://codereview.chromium.org/1864673002/diff/1/ui/app_list/BUILD.gn#newcod...
ui/app_list/BUILD.gn:304: "//ui/resources:ui_test_pak",
This should be :ui_test_pak_data , not :ui_test_pak; :ui_test_pak points to the
file in {{bundle_resources_dir}}.

[mfomitchev, 2016-04-05 21:33:52]

https://codereview.chromium.org/1864673002/diff/1/ui/app_list/BUILD.gn
File ui/app_list/BUILD.gn (right):

https://codereview.chromium.org/1864673002/diff/1/ui/app_list/BUILD.gn#newcod...
ui/app_list/BUILD.gn:304: "//ui/resources:ui_test_pak",
On 2016/04/05 19:52:23, Dirk Pranke wrote:
> This should be :ui_test_pak_data , not :ui_test_pak; :ui_test_pak points to
the
> file in {{bundle_resources_dir}}.

Ah, thanks! I will try that.

[Dirk Pranke, 2016-04-05 21:52:35]

lgtm, assuming you fix the subject and description :).

[mfomitchev, 2016-04-06 19:11:22]

Description was changed from

==========
NOT FOR REVIEW: Using data_deps instead of data.

BUG=NONE
==========

to

==========
Using data_deps instead of data in BUILD.gn for app list test components.

BUG=NONE
==========

[mfomitchev, 2016-04-06 20:53:26]

mfomitchev@chromium.org changed reviewers:
+ xiyuan@chromium.org

[mfomitchev, 2016-04-06 20:53:27]

Tiny cleanup, PTAL.

[xiyuan, 2016-04-06 20:58:33]

lgtm

[mfomitchev, 2016-04-06 21:04:46]

The CQ bit was checked by mfomitchev@chromium.org

[mfomitchev, 2016-04-06 21:04:46]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1864673002/#ps40001
(title: "Same change for ui/app_list/shower/BUILD.gn")

[commit-bot: I haz the power, 2016-04-06 21:05:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864673002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864673002/40001

[commit-bot: I haz the power, 2016-04-06 21:16:17]

Description was changed from

==========
Using data_deps instead of data in BUILD.gn for app list test components.

BUG=NONE
==========

to

==========
Using data_deps instead of data in BUILD.gn for app list test components.

BUG=NONE
==========

[commit-bot: I haz the power, 2016-04-06 21:16:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-06 21:17:49]

Description was changed from

==========
Using data_deps instead of data in BUILD.gn for app list test components.

BUG=NONE
==========

to

==========
Using data_deps instead of data in BUILD.gn for app list test components.

BUG=NONE

Committed: https://crrev.com/12297f7670a17add801cb420b6c89a98b8d8fd13
Cr-Commit-Position: refs/heads/master@{#385555}
==========

[commit-bot: I haz the power, 2016-04-06 21:17:50]

Patchset 3 (id:??) landed as
https://crrev.com/12297f7670a17add801cb420b6c89a98b8d8fd13
Cr-Commit-Position: refs/heads/master@{#385555}