Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: ui/app_list/BUILD.gn

Issue 1864673002: Using data_deps instead of data in BUILD.gn for app list test components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Same change for ui/app_list/shower/BUILD.gn Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/app_list/shower/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/BUILD.gn
diff --git a/ui/app_list/BUILD.gn b/ui/app_list/BUILD.gn
index b90ba0e69b933abb9ec5cada8fb81c90caa18c16..ef310d1d2937206334d254a6deb0547b2e189f07 100644
--- a/ui/app_list/BUILD.gn
+++ b/ui/app_list/BUILD.gn
@@ -282,11 +282,6 @@ test("app_list_unittests") {
"test/run_all_unittests.cc",
]
- # TODO: Add to data_deps instead once GN has rolled past #339778.
- data = [
- "$root_out_dir/ui_test.pak",
- ]
-
configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
deps = [
@@ -302,11 +297,11 @@ test("app_list_unittests") {
"//ui/gfx:test_support",
"//ui/gl:test_support",
"//ui/resources",
- "//ui/resources:ui_test_pak",
]
data_deps = [
"//third_party/mesa:osmesa",
+ "//ui/resources:ui_test_pak_data",
]
if (toolkit_views) {
« no previous file with comments | « no previous file | ui/app_list/shower/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698