Simplify BrowserContext by removing redundant methods.

Simplify BrowserContext by removing redundant methods.

GetRequestContext duplicates BrowserContext::GetDefaultStoragePartition(browser_context)->GetURLRequestContext().

BUG=159193
Committed: https://crrev.com/f26bfb5f167883133d755704bfab8ab8215959c9
Cr-Commit-Position: refs/heads/master@{#386512}

Committed: https://crrev.com/b84299e7eba64691459f4c11688bef958cb6f659
Cr-Commit-Position: refs/heads/master@{#386716}

[jam, 2016-04-11 20:21:24]

jam@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2016-04-11 21:28:02]

lgtm

[jam, 2016-04-11 22:03:59]

The CQ bit was checked by jam@chromium.org

[jam, 2016-04-11 22:03:59]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1864583006/#ps220001
(title: "fix test leak")

[commit-bot: I haz the power, 2016-04-11 22:05:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864583006/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864583006/220001

[commit-bot: I haz the power, 2016-04-11 23:22:35]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-04-11 23:23:39]

Description was changed from

==========
Simplify BrowserContext by removing redundant methods.

GetRequestContext duplicates
BrowserContext::GetDefaultStoragePartition(browser_context)->GetURLRequestContext().

BUG=159193
==========

to

==========
Simplify BrowserContext by removing redundant methods.

GetRequestContext duplicates
BrowserContext::GetDefaultStoragePartition(browser_context)->GetURLRequestContext().

BUG=159193

Committed: https://crrev.com/f26bfb5f167883133d755704bfab8ab8215959c9
Cr-Commit-Position: refs/heads/master@{#386512}
==========

[commit-bot: I haz the power, 2016-04-11 23:23:41]

Patchset 12 (id:??) landed as
https://crrev.com/f26bfb5f167883133d755704bfab8ab8215959c9
Cr-Commit-Position: refs/heads/master@{#386512}

[kjellander_chromium, 2016-04-12 05:19:58]

A revert of this CL (patchset #12 id:220001) has been created in
https://codereview.chromium.org/1878153002/ by kjellander@chromium.org.

The reason for reverting is: Makes
PrecacheManagerTest.StartAndCancelPrecachingBeforeTopHostsCompleted in
components_unittests crash on multiple platforms with an error like this:

[ RUN      ] PrecacheManagerTest.StartAndCancelPrecachingBeforeTopHostsCompleted
[31991:31991:0411/180643:26046834882:ERROR:memory_mapped_file.cc(40)] Couldn't
open /tmp/runZr5HpJ/out/Debug/content_shell.pak
[31991:31991:0411/180643:26046834926:ERROR:data_pack.cc(80)] Failed to mmap
datapack
[31991:31991:0411/180643:26046836597:ERROR:connection.cc(1921)] Precache sqlite
error 14, errno -2: unable to open database file, sql: -- sqlite3_open()
[31991:31991:0411/180643:26046836627:FATAL:connection.cc(1936)] unable to open
database file
#0 0x7ff0fa5c8fde base::debug::StackTrace::StackTrace()
#1 0x7ff0fa62984f logging::LogMessage::~LogMessage()
#2 0x7ff0f6446114 sql::Connection::OnSqliteError()
#3 0x7ff0f64403e0 sql::Connection::OpenInternal()
#4 0x7ff0f643ff7d sql::Connection::Open()
#5 0x0000033857a6 precache::PrecacheDatabase::Init()
#6 0x00000232eaf1
_ZN4base8internal15RunnableAdapterIMN8autofill23AutofillDownloadManagerEFbRKNS3_15FormRequestDataEEE3RunIJS6_EEEbPS3_DpOT_
#7 0x000003382e71
_ZN4base8internal12InvokeHelperILb0EvNS0_15RunnableAdapterIMN8precache16PrecacheDatabaseEFbRKNS_8FilePathEEEEE8MakeItSoIJPS4_S7_EEEvSA_DpOT_
#8 0x000003382e28
_ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1EEEENS0_9BindStateINS0_15RunnableAdapterIMN8precache16PrecacheDatabaseEFbRKNS_8FilePathEEEEFvPS7_SA_EJNS0_17UnretainedWrapperIS7_EERS8_EEENS0_12InvokeHelperILb0EvSD_EEFvvEE3RunEPNS0_13BindStateBaseE
#9 0x7ff0fa5a93be base::Callback<>::Run()
#10 0x7ff0fa5ce9ce base::debug::TaskAnnotator::RunTask()
#11 0x7ff0fa64668c base::MessageLoop::RunTask()
#12 0x7ff0fa646928 base::MessageLoop::DeferOrRunPendingTask()
#13 0x7ff0fa646af2 base::MessageLoop::DoWork()
#14 0x7ff0fa658f9c base::MessagePumpGlib::HandleDispatch()
#15 0x7ff0fa659761 base::(anonymous namespace)::WorkSourceDispatch()
#16 0x7ff0e7fddd13 g_main_context_dispatch
#17 0x7ff0e7fde060 <unknown>
#18 0x7ff0e7fde124 g_main_context_iteration
#19 0x7ff0fa65909f base::MessagePumpGlib::Run()
#20 0x7ff0fa64609f base::MessageLoop::RunHandler()
#21 0x7ff0fa6e6404 base::RunLoop::Run()
#22 0x7ff0fa6e6669 base::RunLoop::RunUntilIdle()
#23 0x0000019ffd7f content::TestBrowserThreadBundle::~TestBrowserThreadBundle()
#24 0x00000151001b precache::(anonymous
namespace)::PrecacheManagerTest::~PrecacheManagerTest()
#25 0x0000015115c5 precache::(anonymous
namespace)::PrecacheManagerTest_StartAndCancelPrecachingBeforeTopHostsCompleted_Test::~PrecacheManagerTest_StartAndCancelPrecachingBeforeTopHostsCompleted_Test()
#26 0x0000015115e9 precache::(anonymous
namespace)::PrecacheManagerTest_StartAndCancelPrecachingBeforeTopHostsCompleted_Test::~PrecacheManagerTest_StartAndCancelPrecachingBeforeTopHostsCompleted_Test()
#27 0x0000008d7c0b base::RefCountedThreadSafe<>::DeleteInternal()
#28 0x00000266960a
_ZN7testing8internal12InvokeHelperIjNSt3tr15tupleIJEEEE12InvokeMethodIN3gfx13GPUTimingFakeEMS8_FjvEEEjPT_T0_RKS4_
#29 0x000003852bde testing::internal::HandleExceptionsInMethodIfSupported<>()
#30 0x000003848190 testing::TestInfo::Run()
#31 0x0000038486ea testing::TestCase::Run()
#32 0x00000384da3c testing::internal::UnitTestImpl::RunAllTests()
#33 0x000003865a2a testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#34 0x00000385425e testing::internal::HandleExceptionsInMethodIfSupported<>()
#35 0x00000384d6df testing::UnitTest::Run()
#36 0x00000079c6c1 RUN_ALL_TESTS()
#37 0x00000079b6f8 base::TestSuite::Run()
#38 0x000000760dd9
_ZN4base8internal15RunnableAdapterIMNS_9TestSuiteEFivEE3RunIJEEEiPS2_DpOT_
#39 0x0000007602dc
_ZN4base8internal12InvokeHelperILb0EiNS0_15RunnableAdapterIMNS_9TestSuiteEFivEEEE8MakeItSoIJPN12_GLOBAL__N_119ComponentsTestSuiteEEEEiS6_DpOT_
#40 0x00000076029d
_ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIMNS_9TestSuiteEFivEEEFiPS6_EJNS0_17UnretainedWrapperIN12_GLOBAL__N_119ComponentsTestSuiteEEEEEENS0_12InvokeHelperILb0EiS9_EEFivEE3RunEPNS0_13BindStateBaseE
#41 0x000000782c6e base::Callback<>::Run()
#42 0x0000007e7586 base::(anonymous namespace)::LaunchUnitTestsInternal()
#43 0x0000007e73ec base::LaunchUnitTests()
#44 0x00000075fa54 main
#45 0x7ff0e4a2176d __libc_start_main
#46 0x00000075f885 <unknown>


I compared the blamelists of the following builds:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg...
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%2...
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...
It gives me this range:
https://chromium.googlesource.com/chromium/src/+log/1007a4af51fee305fd95933d9...
The other two CLs just change scoped_ptr -> unique_ptr and static initializers,
which makes me think the breakage (even if it's strange it didn't fail in CQ),
must be this CL..

[jam, 2016-04-12 15:44:09]

Description was changed from

==========
Simplify BrowserContext by removing redundant methods.

GetRequestContext duplicates
BrowserContext::GetDefaultStoragePartition(browser_context)->GetURLRequestContext().

BUG=159193

Committed: https://crrev.com/f26bfb5f167883133d755704bfab8ab8215959c9
Cr-Commit-Position: refs/heads/master@{#386512}
==========

to

==========
Simplify BrowserContext by removing redundant methods.

GetRequestContext duplicates
BrowserContext::GetDefaultStoragePartition(browser_context)->GetURLRequestContext().

BUG=159193

Committed: https://crrev.com/f26bfb5f167883133d755704bfab8ab8215959c9
Cr-Commit-Position: refs/heads/master@{#386512}
==========

[jam, 2016-04-12 16:12:12]

On 2016/04/12 05:19:58, kjellander (chromium) wrote:
> A revert of this CL (patchset #12 id:220001) has been created in
> https://codereview.chromium.org/1878153002/ by mailto:kjellander@chromium.org.
> 
> The reason for reverting is: Makes
> PrecacheManagerTest.StartAndCancelPrecachingBeforeTopHostsCompleted in
> components_unittests crash on multiple platforms with an error like this:
> 
> [ RUN      ]
PrecacheManagerTest.StartAndCancelPrecachingBeforeTopHostsCompleted
> [31991:31991:0411/180643:26046834882:ERROR:memory_mapped_file.cc(40)] Couldn't
> open /tmp/runZr5HpJ/out/Debug/content_shell.pak
> [31991:31991:0411/180643:26046834926:ERROR:data_pack.cc(80)] Failed to mmap
> datapack
> [31991:31991:0411/180643:26046836597:ERROR:connection.cc(1921)] Precache
sqlite
> error 14, errno -2: unable to open database file, sql: -- sqlite3_open()
> [31991:31991:0411/180643:26046836627:FATAL:connection.cc(1936)] unable to open
> database file
> #0 0x7ff0fa5c8fde base::debug::StackTrace::StackTrace()
> #1 0x7ff0fa62984f logging::LogMessage::~LogMessage()
> #2 0x7ff0f6446114 sql::Connection::OnSqliteError()
> #3 0x7ff0f64403e0 sql::Connection::OpenInternal()
> #4 0x7ff0f643ff7d sql::Connection::Open()
> #5 0x0000033857a6 precache::PrecacheDatabase::Init()
> #6 0x00000232eaf1
>
_ZN4base8internal15RunnableAdapterIMN8autofill23AutofillDownloadManagerEFbRKNS3_15FormRequestDataEEE3RunIJS6_EEEbPS3_DpOT_
> #7 0x000003382e71
>
_ZN4base8internal12InvokeHelperILb0EvNS0_15RunnableAdapterIMN8precache16PrecacheDatabaseEFbRKNS_8FilePathEEEEE8MakeItSoIJPS4_S7_EEEvSA_DpOT_
> #8 0x000003382e28
>
_ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1EEEENS0_9BindStateINS0_15RunnableAdapterIMN8precache16PrecacheDatabaseEFbRKNS_8FilePathEEEEFvPS7_SA_EJNS0_17UnretainedWrapperIS7_EERS8_EEENS0_12InvokeHelperILb0EvSD_EEFvvEE3RunEPNS0_13BindStateBaseE
> #9 0x7ff0fa5a93be base::Callback<>::Run()
> #10 0x7ff0fa5ce9ce base::debug::TaskAnnotator::RunTask()
> #11 0x7ff0fa64668c base::MessageLoop::RunTask()
> #12 0x7ff0fa646928 base::MessageLoop::DeferOrRunPendingTask()
> #13 0x7ff0fa646af2 base::MessageLoop::DoWork()
> #14 0x7ff0fa658f9c base::MessagePumpGlib::HandleDispatch()
> #15 0x7ff0fa659761 base::(anonymous namespace)::WorkSourceDispatch()
> #16 0x7ff0e7fddd13 g_main_context_dispatch
> #17 0x7ff0e7fde060 <unknown>
> #18 0x7ff0e7fde124 g_main_context_iteration
> #19 0x7ff0fa65909f base::MessagePumpGlib::Run()
> #20 0x7ff0fa64609f base::MessageLoop::RunHandler()
> #21 0x7ff0fa6e6404 base::RunLoop::Run()
> #22 0x7ff0fa6e6669 base::RunLoop::RunUntilIdle()
> #23 0x0000019ffd7f
content::TestBrowserThreadBundle::~TestBrowserThreadBundle()
> #24 0x00000151001b precache::(anonymous
> namespace)::PrecacheManagerTest::~PrecacheManagerTest()
> #25 0x0000015115c5 precache::(anonymous
>
namespace)::PrecacheManagerTest_StartAndCancelPrecachingBeforeTopHostsCompleted_Test::~PrecacheManagerTest_StartAndCancelPrecachingBeforeTopHostsCompleted_Test()
> #26 0x0000015115e9 precache::(anonymous
>
namespace)::PrecacheManagerTest_StartAndCancelPrecachingBeforeTopHostsCompleted_Test::~PrecacheManagerTest_StartAndCancelPrecachingBeforeTopHostsCompleted_Test()
> #27 0x0000008d7c0b base::RefCountedThreadSafe<>::DeleteInternal()
> #28 0x00000266960a
>
_ZN7testing8internal12InvokeHelperIjNSt3tr15tupleIJEEEE12InvokeMethodIN3gfx13GPUTimingFakeEMS8_FjvEEEjPT_T0_RKS4_
> #29 0x000003852bde testing::internal::HandleExceptionsInMethodIfSupported<>()
> #30 0x000003848190 testing::TestInfo::Run()
> #31 0x0000038486ea testing::TestCase::Run()
> #32 0x00000384da3c testing::internal::UnitTestImpl::RunAllTests()
> #33 0x000003865a2a
testing::internal::HandleSehExceptionsInMethodIfSupported<>()
> #34 0x00000385425e testing::internal::HandleExceptionsInMethodIfSupported<>()
> #35 0x00000384d6df testing::UnitTest::Run()
> #36 0x00000079c6c1 RUN_ALL_TESTS()
> #37 0x00000079b6f8 base::TestSuite::Run()
> #38 0x000000760dd9
> _ZN4base8internal15RunnableAdapterIMNS_9TestSuiteEFivEE3RunIJEEEiPS2_DpOT_
> #39 0x0000007602dc
>
_ZN4base8internal12InvokeHelperILb0EiNS0_15RunnableAdapterIMNS_9TestSuiteEFivEEEE8MakeItSoIJPN12_GLOBAL__N_119ComponentsTestSuiteEEEEiS6_DpOT_
> #40 0x00000076029d
>
_ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIMNS_9TestSuiteEFivEEEFiPS6_EJNS0_17UnretainedWrapperIN12_GLOBAL__N_119ComponentsTestSuiteEEEEEENS0_12InvokeHelperILb0EiS9_EEFivEE3RunEPNS0_13BindStateBaseE
> #41 0x000000782c6e base::Callback<>::Run()
> #42 0x0000007e7586 base::(anonymous namespace)::LaunchUnitTestsInternal()
> #43 0x0000007e73ec base::LaunchUnitTests()
> #44 0x00000075fa54 main
> #45 0x7ff0e4a2176d __libc_start_main
> #46 0x00000075f885 <unknown>
> 
> 
> I compared the blamelists of the following builds:
>
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg...
>
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2...
>
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%2...
>
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...
> It gives me this range:
>
https://chromium.googlesource.com/chromium/src/+log/1007a4af51fee305fd95933d9...
> The other two CLs just change scoped_ptr -> unique_ptr and static
initializers,
> which makes me think the breakage (even if it's strange it didn't fail in CQ),
> must be this CL..

Thanks for tracking this down. It was a dcheck inside sqlite code that doesn't
get hit in our release-with-asserts build. i'll look to see if it's easy to
update it.

[jam, 2016-04-12 16:30:09]

The CQ bit was checked by jam@chromium.org

[jam, 2016-04-12 16:30:10]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1864583006/#ps260001
(title: "fix")

[commit-bot: I haz the power, 2016-04-12 16:30:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864583006/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864583006/260001

[commit-bot: I haz the power, 2016-04-12 16:59:09]

Description was changed from

==========
Simplify BrowserContext by removing redundant methods.

GetRequestContext duplicates
BrowserContext::GetDefaultStoragePartition(browser_context)->GetURLRequestContext().

BUG=159193

Committed: https://crrev.com/f26bfb5f167883133d755704bfab8ab8215959c9
Cr-Commit-Position: refs/heads/master@{#386512}
==========

to

==========
Simplify BrowserContext by removing redundant methods.

GetRequestContext duplicates
BrowserContext::GetDefaultStoragePartition(browser_context)->GetURLRequestContext().

BUG=159193

Committed: https://crrev.com/f26bfb5f167883133d755704bfab8ab8215959c9
Cr-Commit-Position: refs/heads/master@{#386512}
==========

[commit-bot: I haz the power, 2016-04-12 16:59:12]

Committed patchset #14 (id:260001)

[commit-bot: I haz the power, 2016-04-12 17:01:16]

Description was changed from

==========
Simplify BrowserContext by removing redundant methods.

GetRequestContext duplicates
BrowserContext::GetDefaultStoragePartition(browser_context)->GetURLRequestContext().

BUG=159193

Committed: https://crrev.com/f26bfb5f167883133d755704bfab8ab8215959c9
Cr-Commit-Position: refs/heads/master@{#386512}
==========

to

==========
Simplify BrowserContext by removing redundant methods.

GetRequestContext duplicates
BrowserContext::GetDefaultStoragePartition(browser_context)->GetURLRequestContext().

BUG=159193

Committed: https://crrev.com/f26bfb5f167883133d755704bfab8ab8215959c9
Cr-Commit-Position: refs/heads/master@{#386512}

Committed: https://crrev.com/b84299e7eba64691459f4c11688bef958cb6f659
Cr-Commit-Position: refs/heads/master@{#386716}
==========

[commit-bot: I haz the power, 2016-04-12 17:01:18]

Patchset 14 (id:??) landed as
https://crrev.com/b84299e7eba64691459f4c11688bef958cb6f659
Cr-Commit-Position: refs/heads/master@{#386716}