chrome/browser/extensions/api/dashboard_private/dashboard_private_api.cc - Issue 1864583006: Simplify BrowserContext by removing redundant methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/dashboard_private/dashboard_private_api.cc

Issue 1864583006: Simplify BrowserContext by removing redundant methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/copresence/copresence_api.cc ('k') | chrome/browser/extensions/api/gcd_private/gcd_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/dashboard_private/dashboard_private_api.cc

diff --git a/chrome/browser/extensions/api/dashboard_private/dashboard_private_api.cc b/chrome/browser/extensions/api/dashboard_private/dashboard_private_api.cc

index 146a6f93370ba676cc44bcd7ea6673dd3eb8f636..7f75beddf347ef18f1aef29bacc955cddbd79d1d 100644

--- a/chrome/browser/extensions/api/dashboard_private/dashboard_private_api.cc

+++ b/chrome/browser/extensions/api/dashboard_private/dashboard_private_api.cc

@@ -11,6 +11,7 @@

#include "chrome/browser/bitmap_fetcher/bitmap_fetcher.h"

#include "chrome/browser/profiles/profile.h"

#include "components/crx_file/id_util.h"

+#include "content/public/browser/storage_partition.h"

#include "extensions/common/extension.h"

#include "net/base/load_flags.h"

#include "net/url_request/url_request.h"

@@ -74,8 +75,11 @@ DashboardPrivateShowPermissionPromptForDelegatedInstallFunction::Run() {

}

net::URLRequestContextGetter* context_getter = nullptr;

- if (!icon_url.is_empty())

- context_getter = browser_context()->GetRequestContext();

+ if (!icon_url.is_empty()) {

+ context_getter =

+ content::BrowserContext::GetDefaultStoragePartition(browser_context())->

+ GetURLRequestContext();

+ }

scoped_refptr<WebstoreInstallHelper> helper = new WebstoreInstallHelper(

this, params_->details.id, params_->details.manifest, icon_url,