Make sure BitmapUploader Returns Resources

Make sure BitmapUploader Returns Resources

bitmap_uploader was inheriting from mus::mojom::SurfaceClient directly
instead of from WindowSurfaceClient. Unfortunately, ReturnResources
callbacks were going to the mus client lib and not to BitmapUploader and so
BitmapUploader never returned any resources.

This CL makes BitmapUploader a mus::WindowSurfaceClient and sets itself
as the client for the provided WindowSurface.

BUG=600807
Committed: https://crrev.com/7e1c9478cb013c8c9a485bbc5e3342d6f0a09aac
Cr-Commit-Position: refs/heads/master@{#385655}

[Fady Samuel, 2016-04-06 18:47:49]

fsamuel@chromium.org changed reviewers:
+ rjkroege@chromium.org

[rjkroege, 2016-04-06 18:50:02]

https://codereview.chromium.org/1864543004/diff/1/components/bitmap_uploader/...
File components/bitmap_uploader/bitmap_uploader.h (right):

https://codereview.chromium.org/1864543004/diff/1/components/bitmap_uploader/...
components/bitmap_uploader/bitmap_uploader.h:36: ~BitmapUploader();
don't you need to still override?

[Fady Samuel, 2016-04-06 18:52:18]

PTAL Rob!

https://codereview.chromium.org/1864543004/diff/1/components/bitmap_uploader/...
File components/bitmap_uploader/bitmap_uploader.h (right):

https://codereview.chromium.org/1864543004/diff/1/components/bitmap_uploader/...
components/bitmap_uploader/bitmap_uploader.h:36: ~BitmapUploader();
On 2016/04/06 18:50:02, rjkroege wrote:
> don't you need to still override?

Done.

[rjkroege, 2016-04-06 19:08:51]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2016-04-06 19:08:52]

The CQ bit was unchecked by rjkroege@chromium.org

[rjkroege, 2016-04-06 19:09:01]

lgtm

[Fady Samuel, 2016-04-06 19:11:36]

fsamuel@chromium.org changed reviewers:
+ sky@chromium.org

[Fady Samuel, 2016-04-06 19:11:37]

+sky@ for components/mus. PTAL!

[Fady Samuel, 2016-04-06 19:11:37]

+sky@ for components/mus. PTAL!

[sky, 2016-04-07 03:15:57]

LGTM

https://codereview.chromium.org/1864543004/diff/20001/components/bitmap_uploa...
File components/bitmap_uploader/bitmap_uploader.h (right):

https://codereview.chromium.org/1864543004/diff/20001/components/bitmap_uploa...
components/bitmap_uploader/bitmap_uploader.h:33: :
NON_EXPORTED_BASE(mus::WindowSurfaceClient) {
public?

[Fady Samuel, 2016-04-07 03:28:51]

CQ'ing.

https://codereview.chromium.org/1864543004/diff/20001/components/bitmap_uploa...
File components/bitmap_uploader/bitmap_uploader.h (right):

https://codereview.chromium.org/1864543004/diff/20001/components/bitmap_uploa...
components/bitmap_uploader/bitmap_uploader.h:33: :
NON_EXPORTED_BASE(mus::WindowSurfaceClient) {
On 2016/04/07 03:15:57, sky wrote:
> public?

Done.

[Fady Samuel, 2016-04-07 03:28:59]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-04-07 03:28:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1864543004/#ps40001
(title: "Addressed Scott's comment")

[commit-bot: I haz the power, 2016-04-07 03:29:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864543004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864543004/40001

[commit-bot: I haz the power, 2016-04-07 04:16:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-07 04:18:31]

Description was changed from

==========
Make sure BitmapUploader Returns Resources

bitmap_uploader was inheriting from mus::mojom::SurfaceClient directly
instead of from WindowSurfaceClient. Unfortunately, ReturnResources
callbacks were going to the mus client lib and not to BitmapUploader and so
BitmapUploader never returned any resources.

This CL makes BitmapUploader a mus::WindowSurfaceClient and sets itself
as the client for the provided WindowSurface.

BUG=600807
==========

to

==========
Make sure BitmapUploader Returns Resources

bitmap_uploader was inheriting from mus::mojom::SurfaceClient directly
instead of from WindowSurfaceClient. Unfortunately, ReturnResources
callbacks were going to the mus client lib and not to BitmapUploader and so
BitmapUploader never returned any resources.

This CL makes BitmapUploader a mus::WindowSurfaceClient and sets itself
as the client for the provided WindowSurface.

BUG=600807

Committed: https://crrev.com/7e1c9478cb013c8c9a485bbc5e3342d6f0a09aac
Cr-Commit-Position: refs/heads/master@{#385655}
==========

[commit-bot: I haz the power, 2016-04-07 04:18:32]

Patchset 3 (id:??) landed as
https://crrev.com/7e1c9478cb013c8c9a485bbc5e3342d6f0a09aac
Cr-Commit-Position: refs/heads/master@{#385655}