Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: components/bitmap_uploader/bitmap_uploader.h

Issue 1864543004: Make sure BitmapUploader Returns Resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Scott's comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/bitmap_uploader/bitmap_uploader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/bitmap_uploader/bitmap_uploader.h
diff --git a/components/bitmap_uploader/bitmap_uploader.h b/components/bitmap_uploader/bitmap_uploader.h
index 65162ac9c2b56e45341e62eeff205b7fc670fe83..48efe009f08ab713d372fb977a2d0657ee9e06b4 100644
--- a/components/bitmap_uploader/bitmap_uploader.h
+++ b/components/bitmap_uploader/bitmap_uploader.h
@@ -12,6 +12,7 @@
#include "base/macros.h"
#include "components/bitmap_uploader/bitmap_uploader_export.h"
#include "components/mus/public/cpp/window_surface.h"
+#include "components/mus/public/cpp/window_surface_client.h"
#include "components/mus/public/interfaces/compositor_frame.mojom.h"
#include "components/mus/public/interfaces/gpu.mojom.h"
#include "gpu/GLES2/gl2chromium.h"
@@ -29,7 +30,7 @@ BITMAP_UPLOADER_EXPORT extern const char kBitmapUploaderForAcceleratedWidget[];
// BitmapUploader is useful if you want to draw a bitmap or color in a
// mus::Window.
class BITMAP_UPLOADER_EXPORT BitmapUploader
- : NON_EXPORTED_BASE(public mus::mojom::SurfaceClient) {
+ : public NON_EXPORTED_BASE(mus::WindowSurfaceClient) {
public:
explicit BitmapUploader(mus::Window* window);
~BitmapUploader() override;
@@ -61,8 +62,9 @@ class BITMAP_UPLOADER_EXPORT BitmapUploader
void SetIdNamespace(uint32_t id_namespace);
- // SurfaceClient implementation.
- void ReturnResources(
+ // WindowSurfaceClient implementation.
+ void OnResourcesReturned(
+ mus::WindowSurface* surface,
mojo::Array<mus::mojom::ReturnedResourcePtr> resources) override;
mus::Window* window_;
@@ -79,7 +81,6 @@ class BITMAP_UPLOADER_EXPORT BitmapUploader
uint32_t next_resource_id_;
uint32_t id_namespace_;
base::hash_map<uint32_t, uint32_t> resource_to_texture_id_map_;
- mojo::Binding<mus::mojom::SurfaceClient> surface_client_binding_;
DISALLOW_COPY_AND_ASSIGN(BitmapUploader);
};
« no previous file with comments | « no previous file | components/bitmap_uploader/bitmap_uploader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698