Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: media/audio/mac/audio_low_latency_input_mac.cc

Issue 1864483002: Forward output glitch information from stream WebRTC log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/mac/audio_low_latency_input_mac.cc
diff --git a/media/audio/mac/audio_low_latency_input_mac.cc b/media/audio/mac/audio_low_latency_input_mac.cc
index d351940041d9b892f4be92be6477d990c850a514..5c711b748c72908e9680e2b69e64737f53f531d7 100644
--- a/media/audio/mac/audio_low_latency_input_mac.cc
+++ b/media/audio/mac/audio_low_latency_input_mac.cc
@@ -14,6 +14,7 @@
#include "base/metrics/sparse_histogram.h"
#include "base/sys_info.h"
#include "base/time/time.h"
+#include "media/audio/audio_logging.h"
#include "media/audio/mac/audio_manager_mac.h"
#include "media/base/audio_bus.h"
#include "media/base/data_buffer.h"
@@ -1327,6 +1328,8 @@ void AUAudioInputStream::ReportAndResetStats() {
// A value of 0 indicates that we got the buffer size we asked for.
UMA_HISTOGRAM_COUNTS_10000("Media.Audio.Capture.FramesProvided",
number_of_frames_provided_);
+ WebRtcLogMessage("(Example) Here the stats will be logged.");
DaleCurtis 2016/04/05 21:56:52 No, this is a layering violation. media/ shouldn't
Henrik Grunell 2016/04/06 12:25:31 What about adding something like AudioLog::OnStati
+
// Even if there aren't any glitches, we want to record it to get a feel for
// how often we get no glitches vs the alternative.
UMA_HISTOGRAM_COUNTS("Media.Audio.Capture.Glitches", glitches_detected_);

Powered by Google App Engine
This is Rietveld 408576698