Forward output glitch information from stream WebRTC log

media/audio/mac/audio_low_latency_input_mac.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/audio/mac/audio_low_latency_input_mac.h"
 #include <CoreServices/CoreServices.h>
 #include <mach/mach.h>
 #include <string>
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/mac/mac_logging.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/metrics/sparse_histogram.h"
 #include "base/sys_info.h"
 #include "base/time/time.h"
+#include "media/audio/audio_logging.h"
 #include "media/audio/mac/audio_manager_mac.h"
 #include "media/base/audio_bus.h"
 #include "media/base/data_buffer.h"
 
 namespace media {
 
 // Number of blocks of buffers used in the |fifo_|.
 const int kNumberOfBlocksBufferInFifo = 2;
 
 // Max length of sequence of TooManyFramesToProcessError errors.
@@ skipping 1293 matching lines @@
   last_sample_time_ = timestamp->mSampleTime;
 }
 
 void AUAudioInputStream::ReportAndResetStats() {
   if (last_sample_time_ == 0)
     return;  // No stats gathered to report.
 
   // A value of 0 indicates that we got the buffer size we asked for.
   UMA_HISTOGRAM_COUNTS_10000("Media.Audio.Capture.FramesProvided",
                              number_of_frames_provided_);
+  WebRtcLogMessage("(Example) Here the stats will be logged.");

[DaleCurtis, 2016/04/05 21:56:52]

No, this is a layering violation. media/ shouldn't know anything about WebRTC.
This should be some generic logging infrastructure (likely attached to the
existing AudioLog).

[Henrik Grunell, 2016/04/06 12:25:31]

What about adding something like
AudioLog::OnStatistic(int component_id, const std::string& name, int value);
?
And use like:
audio_log->OnStatistic(stream_id, "Media.Audio.Capture.Glitches",
glitches_detected_);

Then media internals can format and forward to the WebRTC log (maybe filtered on
stat name), and in the future we could add presentation of component specific
stats in media-interals (I think that would be useful).

+
   // Even if there aren't any glitches, we want to record it to get a feel for
   // how often we get no glitches vs the alternative.
   UMA_HISTOGRAM_COUNTS("Media.Audio.Capture.Glitches", glitches_detected_);
 
   if (glitches_detected_ != 0) {
     auto lost_frames_ms = (total_lost_frames_ * 1000) / format_.mSampleRate;
     UMA_HISTOGRAM_LONG_TIMES("Media.Audio.Capture.LostFramesInMs",
                              base::TimeDelta::FromMilliseconds(lost_frames_ms));
     auto largest_glitch_ms =
         (largest_glitch_frames_ * 1000) / format_.mSampleRate;
     UMA_HISTOGRAM_CUSTOM_TIMES(
         "Media.Audio.Capture.LargestGlitchMs",
         base::TimeDelta::FromMilliseconds(largest_glitch_ms),
         base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromMinutes(1),
         50);
     DLOG(WARNING) << "Total glitches=" << glitches_detected_
                   << ". Total frames lost=" << total_lost_frames_ << " ("
                   << lost_frames_ms;
   }
 
   number_of_frames_provided_ = 0;
   glitches_detected_ = 0;
   last_sample_time_ = 0;
   last_number_of_frames_ = 0;
   total_lost_frames_ = 0;
   largest_glitch_frames_ = 0;
 }
 
 }  // namespace media