Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: media/audio/audio_output_dispatcher_impl.cc

Issue 1864483002: Forward output glitch information from stream WebRTC log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Finished up for review. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_output_dispatcher_impl.cc
diff --git a/media/audio/audio_output_dispatcher_impl.cc b/media/audio/audio_output_dispatcher_impl.cc
index b29009ab04d5d1089ea114af3c6a65759d1f9322..c945ea8307b5ba0d6e059c9e096ca2b375db8e45 100644
--- a/media/audio/audio_output_dispatcher_impl.cc
+++ b/media/audio/audio_output_dispatcher_impl.cc
@@ -147,7 +147,8 @@ bool AudioOutputDispatcherImpl::HasOutputProxies() const {
bool AudioOutputDispatcherImpl::CreateAndOpenStream() {
DCHECK(task_runner_->BelongsToCurrentThread());
AudioOutputStream* stream = audio_manager_->MakeAudioOutputStream(
DaleCurtis 2016/05/19 20:34:37 Just bind this directly to the audio log, since it
Henrik Grunell 2016/05/23 17:13:55 Good point, done.
- params_, device_id_);
+ params_, device_id_,
+ base::Bind(&AudioOutputDispatcherImpl::OnStatistics, this));
if (!stream)
return false;
@@ -186,4 +187,12 @@ void AudioOutputDispatcherImpl::CloseIdleStreams(size_t keep_alive) {
idle_streams_.erase(idle_streams_.begin() + keep_alive, idle_streams_.end());
}
+void AudioOutputDispatcherImpl::OnStatistics(AudioOutputStream* physical_stream,
+ const std::string& name,
+ int value) {
+ auto it = audio_stream_ids_.find(physical_stream);
o1ka 2016/05/18 14:00:17 Is there a guarantee that access to |audio_stream_
Henrik Grunell 2016/05/23 17:13:55 This function has been removed.
+ DCHECK(it != audio_stream_ids_.end());
+ audio_log_->OnStatistics(it->second, name, value);
+}
+
} // namespace media

Powered by Google App Engine
This is Rietveld 408576698