Forward output glitch information from stream WebRTC log

media/audio/audio_output_dispatcher_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/audio/audio_output_dispatcher_impl.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
@@ skipping 128 matching lines @@
       << "Active proxy streams during shutdown: "
       << proxy_to_physical_map_.size();
 }
 
 bool AudioOutputDispatcherImpl::HasOutputProxies() const {
   return idle_proxies_ || !proxy_to_physical_map_.empty();
 }
 
 bool AudioOutputDispatcherImpl::CreateAndOpenStream() {
   DCHECK(task_runner_->BelongsToCurrentThread());
   AudioOutputStream* stream = audio_manager_->MakeAudioOutputStream(

[DaleCurtis, 2016/05/19 20:34:37]

Just bind this directly to the audio log, since it owns the stream.

[Henrik Grunell, 2016/05/23 17:13:55]

Good point, done.

-      params_, device_id_);
+      params_, device_id_,
+      base::Bind(&AudioOutputDispatcherImpl::OnStatistics, this));
   if (!stream)
     return false;
 
   if (!stream->Open()) {
     stream->Close();
     return false;
   }
 
   const int stream_id = audio_stream_id_++;
   audio_stream_ids_[stream] = stream_id;
@@ skipping 18 matching lines @@
     stream->Close();
 
     AudioStreamIDMap::iterator it = audio_stream_ids_.find(stream);
     DCHECK(it != audio_stream_ids_.end());
     audio_log_->OnClosed(it->second);
     audio_stream_ids_.erase(it);
   }
   idle_streams_.erase(idle_streams_.begin() + keep_alive, idle_streams_.end());
 }
 
+void AudioOutputDispatcherImpl::OnStatistics(AudioOutputStream* physical_stream,
+                                             const std::string& name,
+                                             int value) {
+  auto it = audio_stream_ids_.find(physical_stream);

[o1ka, 2016/05/18 14:00:17]

Is there a guarantee that access to |audio_stream_ids_| is thread safe?

[Henrik Grunell, 2016/05/23 17:13:55]

This function has been removed.

+  DCHECK(it != audio_stream_ids_.end());
+  audio_log_->OnStatistics(it->second, name, value);
+}
+
 }  // namespace media