Repeats and fixes the changes landed & reverted as CL 1789553003.

Repeats and fixes the changes landed & reverted as CL 1789553003.

When landed, CL 1789553003 turned out to cause bot failures because
some libraries outside the compiler are importing compiler libraries
which have been updated. For instance, the tests in 'compiler/dart2js'
depend on several internal elements of the 'dart2js' compiler.

This CL updates these external dependents to work with the modified
library structure and class APIs of the compiler. A small adjustment
was applied to 'dart2js_incremental' as well.

No further dependents are believed to exist: Grepping in sdk for
relevant imports does not reveal any further imports of any of the
libraries in the compiler where the "interface" has changed, and
external clients are not supported (that is, imports in arbitrary
github repositories may or may not break if they use the compiler
internals, but we do not support this type of dependency so we won't
do anything to protect them against that type of breakage).

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/586c43ac7eaf55c7127c869e5468a43af1594a15

[eernst, 2016-04-05 11:52:18]

eernst@google.com changed reviewers:
+ johnniwinther@google.com

[eernst, 2016-04-05 11:52:18]

Patch set 1 is identical to https://codereview.chromium.org/1789553003/ which
was landed and reverted, and patch set 2 contains the changes needed to fix the
bot failures with that CL.

Hence, reviewing can ignore patch set 1 and focus only on patch set 2 and up.

[Johnni Winther, 2016-04-05 11:59:05]

lgtm

[eernst, 2016-04-05 15:26:21]

Description was changed from

==========
Repeats and fixes the changes landed & reverted as CL 1789553003.

When landed, CL 1789553003 turned out to cause bot failures because
some libraries outside the compiler are importing compiler libraries
which have been updated. For instance, the tests in 'compiler/dart2js'
depend on several internal elements of the 'dart2js' compiler.

This CL updates these external dependents to work with the modified
library structure and class APIs of the compiler. A small adjustment
was applied to 'dart2js_incremental' as well.

No further dependents are believed to exist: Grepping in sdk for
relevant imports does not reveal any further imports of any of the
libraries in the compiler where the "interface" has changed, and
external clients are not supported (that is, imports in arbitrary
github repositories may or may not break if they use the compiler
internals, but we do not support this type of dependency so we won't
do anything to protect them against that type of breakage).
==========

to

==========
Repeats and fixes the changes landed & reverted as CL 1789553003.

When landed, CL 1789553003 turned out to cause bot failures because
some libraries outside the compiler are importing compiler libraries
which have been updated. For instance, the tests in 'compiler/dart2js'
depend on several internal elements of the 'dart2js' compiler.

This CL updates these external dependents to work with the modified
library structure and class APIs of the compiler. A small adjustment
was applied to 'dart2js_incremental' as well.

No further dependents are believed to exist: Grepping in sdk for
relevant imports does not reveal any further imports of any of the
libraries in the compiler where the "interface" has changed, and
external clients are not supported (that is, imports in arbitrary
github repositories may or may not break if they use the compiler
internals, but we do not support this type of dependency so we won't
do anything to protect them against that type of breakage).

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/586c43ac7eaf55c7127c869e5468a43af1594a15
==========

[eernst, 2016-04-05 15:26:23]

Committed patchset #2 (id:20001) manually as
586c43ac7eaf55c7127c869e5468a43af1594a15 (presubmit successful).